error-reporting: Fix README typos showing usage#2316
error-reporting: Fix README typos showing usage#2316stephenplusplus merged 3 commits intogoogleapis:masterfrom
Conversation
|
Changes Unknown when pulling 54ad09e on DominicKramer:docs/update-README-usage-typo into ** on GoogleCloudPlatform:master**. |
packages/error-reporting/README.md
Outdated
| var errors = require('@google-cloud/error-reporting')(); | ||
| var koa = require('koa'); | ||
| var app = koa(); | ||
| var app = new koa(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling a738e57 on DominicKramer:docs/update-README-usage-typo into ** on GoogleCloudPlatform:master**. |
|
LGTM -- do you want to ping anyone else for a review? |
|
@stephenplusplus I've sent another review out. |
| var errors = require('@google-cloud/error-reporting')(); | ||
| var koa = require('koa'); | ||
| var app = koa(); | ||
| var Koa = require('koa'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@stephenplusplus The test failures look unrelated to this PR. Other than the test failures, this PR is ready to land. |
|
Could you paste the errors from Circle? Mobile and Circle log outputs do not get along. |
|
@stephenplusplus Below are sections of the test output that I think are relevant. |
|
Thanks! |
No description provided.