Skip to content

common: do not require options #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenplusplus merged 1 commit into from
Aug 25, 2017
Merged

common: do not require options #2563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/common/src/service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ var PROJECT_ID_TOKEN = '{{projectId}}';
* @param {object} config - Configuration object.
* @param {string} config.baseUrl - The base URL to make API requests to.
* @param {string[]} config.scopes - The scopes required for the request.
* @param {object} options - [Configuration object](#/docs).
* @param {object=} options - [Configuration object](#/docs).
*/
function Service(config, options) {
options = options || {};

var reqCfg = extend({}, config, {
credentials: options.credentials,
keyFile: options.keyFilename,
Expand Down
6 changes: 6 additions & 0 deletions packages/common/test/service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ describe('Service', function() {
});

describe('instantiation', function() {
it('should not require options', function() {
assert.doesNotThrow(function() {
new Service(CONFIG);
});
});

it('should create an authenticated request factory', function() {
var authenticatedRequest = {};

Expand Down