use path.resolve to find keyfile path #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
added a commit
that referenced
this pull request
Apr 21, 2015
use path.resolve to find keyfile path
Contributor
|
Smart! Didn't even think of this. |
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.1.2...v3.2.0) (2020-12-08) ### Features * person detection samples to GA ([#504](https://www.github.com/googleapis/nodejs-video-intelligence/issues/504)) ([eec2a65](https://www.github.com/googleapis/nodejs-video-intelligence/commit/eec2a653aa635716c2d455152867ea2eef10d284)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.1.2...v3.2.0) (2020-12-08) ### Features * person detection samples to GA ([#504](https://www.github.com/googleapis/nodejs-video-intelligence/issues/504)) ([eec2a65](https://www.github.com/googleapis/nodejs-video-intelligence/commit/eec2a653aa635716c2d455152867ea2eef10d284)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This was referenced Nov 9, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-dataproc/compare/v2.4.2...v2.4.3) (2021-06-29) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#508](https://www.github.com/googleapis/nodejs-dataproc/issues/508)) ([e03b476](https://www.github.com/googleapis/nodejs-dataproc/commit/e03b47670de476c14a48b99cbb8c0dcd2c0c813c)) * make request optional in all cases ([#504](https://www.github.com/googleapis/nodejs-dataproc/issues/504)) ([c14a8a8](https://www.github.com/googleapis/nodejs-dataproc/commit/c14a8a8dc6d672cc05b23cf255486be4b865ac6e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* chore(deps): update dependency gts to v3 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Megan O'Keefe <3137106+askmeegs@users.noreply.github.com>
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/0d9476f5-156e-4a9b-9f97-94473eb544b9/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@15013ef
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
Committer: @alexander-fenster PiperOrigin-RevId: 372656503 Source-Link: googleapis/googleapis@6fa858c Source-Link: googleapis/googleapis-gen@d7c95df
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
* build: add new kokoro config for release-please and coverage * build: actually commit the config * fix: do not fail test if nyc did not run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #484
This will create a full path to the keyfile, re-enabling our tests to run after merge. Going to merge this straight away so we can merge #504 and have the docs built.
This should be future-proof for when the env var changes as well.