Storage: add move method to File object #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lib/storage/file.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
I like the idea. And code looks great! Can you squash your commits to get rid of those messy merge commits 😃 thanks! |
Contributor
|
I like these helpers, too. Thanks! |
test/storage/file.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
I fixed the mess I did with merges and made other corrections. Tests should now be better but please double-check them:) |
Contributor
|
Awesome, thank you! Look how happy you made gcloud: (Those are tears of joy) |
stephenplusplus
added a commit
that referenced
this pull request
May 8, 2015
Storage: add move method to File object
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 15, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/nodejs-redis/compare/v2.3.1...v2.4.0) (2021-11-10) ### Features * [Cloud Memorystore for Redis] Support Multiple Read Replicas when creating Instance ([#526](https://www.github.com/googleapis/nodejs-redis/issues/526)) ([ea43df2](https://www.github.com/googleapis/nodejs-redis/commit/ea43df28f39b1943f0c9aea97df51252f4cc2a9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
Update npm scripts: add clean, prelint, prefix; make sure that lint and fix are set properly. Use post-process feature of synthtool.
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.4](https://www.github.com/googleapis/nodejs-text-to-speech/compare/v3.2.3...v3.2.4) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#529](https://www.github.com/googleapis/nodejs-text-to-speech/issues/529)) ([5c6c68c](https://www.github.com/googleapis/nodejs-text-to-speech/commit/5c6c68cb54aa684a4d2f33cedc6565ef2f17e153)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
* fix: GoogleAdsError missing using generator version after 1.3.0 [PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343 * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.2](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.1...v2.3.2) (2021-05-25) ### Bug Fixes * GoogleAdsError missing using generator version after 1.3.0 ([#529](https://www.github.com/googleapis/nodejs-tasks/issues/529)) ([760c204](https://www.github.com/googleapis/nodejs-tasks/commit/760c2043f9bccb0d2787e83dd08ace942e6b10fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* chore(main): release 3.0.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* feat: fetch for default branch Source-Author: Billy Jacobson <billyjacobson@users.noreply.github.com> Source-Date: Thu Apr 15 20:13:42 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: 898b38a6f4fab89a76dfb152480bb034a781331b Source-Link: googleapis/synthtool@898b38a * build(node): remove unused tokens Source-Author: Benjamin E. Coe <bencoe@google.com> Source-Date: Fri Apr 16 10:12:05 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: b33b0e2056a85fc2264b294f2cf47dcd45e95186 Source-Link: googleapis/synthtool@b33b0e2 * fix(node): default-branch should use $default_branch Source-Author: Benjamin E. Coe <bencoe@google.com> Source-Date: Fri Apr 16 10:25:52 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: c6706ee5d693e9ae5967614170732646590d8374 Source-Link: googleapis/synthtool@c6706ee
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/ba2d388f-b3b2-4ad7-a163-0c6b4d86894f/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@05de3e1
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.1](googleapis/nodejs-dns@v3.0.0...v3.0.1) (2022-06-09) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#529](googleapis/nodejs-dns#529)) ([4e8b02f](googleapis/nodejs-dns@4e8b02f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple move function for a File object. It uses the already available copy and delete.
I also added some unit tests.