Skip to content

feat:[Spanner] CacheSessionPool::maintain deletes sessions older than 28d #5853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bshaffer merged 1 commit into from
Feb 22, 2023
Merged

feat:[Spanner] CacheSessionPool::maintain deletes sessions older than 28d #5853

bshaffer merged 1 commit into from
Feb 22, 2023

Conversation

@vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Feb 3, 2023 •
edited
Loading

Potentially fixes: #5827

Changes

  1. Adds a check in maintain() to purge sessions older than 28d.
  2. Also modifies checks in CacheSessionPool::isSessionValid(..)
  3. Other changes necessary to retain ['creation'] param, which is set to time in seconds when session was created and only used to check for expiration.
  4. Relevant additions to system and unit tests

Tests

Both UT and System tests are passing in prod.

@vishwarajanand vishwarajanand marked this pull request as ready for review February 3, 2023 19:03
@vishwarajanand vishwarajanand requested review from a team as code owners February 3, 2023 19:03
@vishwarajanand vishwarajanand mentioned this pull request Feb 3, 2023
Closed
bshaffer
bshaffer requested changes Feb 10, 2023
View reviewed changes
@vishwarajanand
Copy link
Contributor Author

vishwarajanand commented Feb 11, 2023

@bshaffer I force-pushed to get rid of conventional commit error, due to first commit.

@bshaffer bshaffer added the next release PRs to be included in the next release label Feb 19, 2023
bshaffer
bshaffer reviewed Feb 21, 2023
View reviewed changes
@bshaffer bshaffer merged commit fbf2081 into googleapis:main Feb 22, 2023
@release-please release-please bot mentioned this pull request Feb 22, 2023
Merged
bshaffer pushed a commit that referenced this pull request Mar 21, 2023
@vishwarajanand @bshaffer
feat:[Spanner] CacheSessionPool::maintain deletes sessions older than…
f31ba3a 
… 28d (#5853)
@taka-oyama taka-oyama mentioned this pull request Aug 17, 2023
Merged
@MostafaOmar98 MostafaOmar98 mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees

No one assigned

Labels

next release PRs to be included in the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spanner: Deleted sessions are not removed from the session pool

2 participants

@vishwarajanand @bshaffer