ensures servicebuilder throws proper exceptions#682
Merged
dwsupplee merged 2 commits intogoogleapis:masterfrom Sep 26, 2017
Merged
ensures servicebuilder throws proper exceptions#682dwsupplee merged 2 commits intogoogleapis:masterfrom
dwsupplee merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
dwsupplee
approved these changes
Sep 25, 2017
Contributor
dwsupplee
left a comment
dwsupplee
left a comment
There was a problem hiding this comment.
I could have sworn this was throwing exceptions when I last reviewed it 😕. Either way, lgtm!
Contributor
Author
|
It was, but then the service builder was changed and I must have goofed the rebase. I'm more curious why the tests didn't fail. |
Contributor
Author
|
The code coverages are inaccurate... I believe it is because the system test ( |
Contributor
Author
|
Ahh yes, the system tests are only run on the cron. I moved the test from |
bshaffer
force-pushed
the
ensure-servicebuilder-throw-exception
branch
from
85767dc to
a4708bc
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.