Skip to content

fix(bigquery): fix minimum version of dependency #10016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plamut merged 1 commit into from
Jan 9, 2020
Merged

fix(bigquery): fix minimum version of dependency #10016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bigquery/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
'enum34; python_version < "3.4"',
"google-auth >= 1.9.0, < 2.0dev",
"google-api-core >= 1.15.0, < 2.0dev",
"google-cloud-core >= 1.0.3, < 2.0dev",
"google-resumable-media >= 0.3.1, != 0.4.0, < 0.6.0dev",
"google-cloud-core >= 1.1.0, < 2.0dev",
"google-resumable-media >= 0.5.0, < 0.6dev",
Copy link
Contributor

@plamut plamut Dec 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this version bump needed? Looking at the release notes, there have been no bugfixes since 0.3.1, and the only new feature is raw download classes (released in 0.5.0).

Not that I'm opposing it, just asking as a sanity check.

(besides, google-resumable-media version pin will have to be updated soon anyway when #10005 is implemented)

Copy link
Contributor Author

@HemangChothani HemangChothani Dec 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plamut Not any specific reason, for the raw download feature and found in setup.py file of storage so update it,so if you recommend i will revert back to 0.3.1.

Copy link
Contributor

@crwilcox crwilcox Jan 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory not much has changed. And you could likely only take core (I am pretty sure given a recent change that is required). The grouping of resumable-media was to keep storage and bigquery in sync with what they require to hopefully avoid odd incompatibilities.

Copy link
Contributor

@plamut plamut Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it appears safe, let's keep the resumable-media version bump then for the reason Chris mentioned.

"protobuf >= 3.6.0",
"six >=1.13.0,< 2.0.0dev",
]
Expand Down