fix(storage): blob metadata to None regression #10108
Conversation
IlyaFaer
added
type: bug
googlebot
added
the
cla: yes
|
|
| """ | ||
| value = {k: str(v) for k, v in value.items()} | ||
| if value is not None: | ||
| value = {k: str(v) for k, v in value.items()} |
There was a problem hiding this comment.
value has tag Optional, so it really looks like a regression
Do we need to do the same thing for bucket labels? I don't see Optional tag for them. Still, stringifying was added for them
There was a problem hiding this comment.
I think the documentation is incorrect. The code is correct in that the property metadata is optional but should not be optional when setting this value.
There was a problem hiding this comment.
Okay, I've deleted Optional tag. As I see, it was added by some kind of a script
| """ | ||
| value = {k: str(v) for k, v in value.items()} | ||
| if value is not None: | ||
| value = {k: str(v) for k, v in value.items()} |
There was a problem hiding this comment.
I think the documentation is incorrect. The code is correct in that the property metadata is optional but should not be optional when setting this value.
3 participants
Fixes #10107