Skip to content

chore(recommender): use artman for generation instead of bazel #10356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 2 commits into from
Feb 7, 2020
Merged

chore(recommender): use artman for generation instead of bazel #10356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14c5033
fix: use artman, not bazel
busunkim96 Feb 6, 2020
a2a5995
chore: blacken
busunkim96 Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions recommender/synth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from synthtool import gcp
from synthtool.languages import python

gapic = gcp.GAPICBazel()
gapic = gcp.GAPICGenerator()
versions = ["v1beta1", "v1"]
common = gcp.CommonTemplates()

Expand All @@ -28,7 +28,11 @@
# Generate Cloud Recommender
# ----------------------------------------------------------------------------
for version in versions:
library = gapic.py_library("recommender", version)
library = gapic.py_library(
"recommender",
version,
config_path=f"/google/cloud/recommender/{version}/artman_recommender_{version}.yaml",
)
s.move(library, excludes=["nox.py", "docs/index.rst", "README.rst", "setup.py"])

# Fix docstring with regex pattern that breaks docgen
Expand All @@ -37,7 +41,12 @@
# Fix more regex in docstrings
s.replace("google/**/*_pb2.py", ":math:`(/)", "\g<1>")
s.replace("google/**/*_pb2.py", "`/\.", "/.")
s.replace("google/**/*_pb2.py", "(regex\s+)(/.*?/)\.", "\g<1>``\g<2>``.", flags=re.MULTILINE | re.DOTALL,)
s.replace(
"google/**/*_pb2.py",
"(regex\s+)(/.*?/)\.",
"\g<1>``\g<2>``.",
flags=re.MULTILINE | re.DOTALL,
)

# Fix docstring with JSON example by wrapping with backticks
s.replace(
Expand Down