Collapsing sub-package explosion in Travis config into a script. #2473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script will be extended a great deal in coming commits.
googlebot
added
the
cla: yes
Contributor
Author
|
Green build before I pushed 2nd commit: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/164164263 |
dhermes
force-pushed
the
collapse-travis-config
branch
from
a3ec46f to
d7f79cd
Compare
Contributor
Author
|
@tseaver PTAL |
daspecster
reviewed
Oct 3, 2016
| msg_parts.append('- ' + package) | ||
| msg = '\n'.join(msg_parts) | ||
| print(msg, file=sys.stderr) | ||
| sys.exit(len(failed_packages)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Merging as-is, putting fix for the error code issue in #2475. |
Contributor
Author
|
Fingers crossed AppVeyor goes green: https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.767.master |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script will be extended a great deal in coming commits.
Note that this doesn't actually make the tests run faster, but it's a minimal change for a PR and I will be sending lots of changes on top of it.
Also, this fixes the current b0rken state of AppVeyor, so that's a plus.
Also, the 2nd commit uses a lesser known feature of
tox: