bigquery: add Client.list_rows, remove Table.fetch_data by jba · Pull Request #4119 · googleapis/google-cloud-python

jba · 2017-10-04T18:52:42Z

No description provided.

bigquery/google/cloud/bigquery/client.py

+            The fields to return. Required if ``table`` is a
+            :class:`~google.cloud.bigquery.table.TableReference`.
+
+        :type max_results: int


bigquery/google/cloud/bigquery/client.py

+            :class:`~google.cloud.bigquery.table.TableReference`.
+
+        :type max_results: int
+        :param max_results: (Optional) Maximum number of rows to return.


bigquery/tests/unit/test_client.py

+        local_number = SchemaField('local_number', 'STRING', 'REQUIRED')
+        rank = SchemaField('rank', 'INTEGER', 'REQUIRED')
+        phone = SchemaField('phone', 'RECORD', mode='NULLABLE',
+                            fields=[area_code, local_number, rank])


bigquery/google/cloud/bigquery/client.py

+            items_key='rows',
+            page_token=page_token,
+            next_token='pageToken',
+            max_results=max_results,


jba requested review from alixhami, tseaver and tswast October 4, 2017 18:52

jba requested a review from lukesneeringer as a code owner October 4, 2017 18:52

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2017

tswast requested changes Oct 4, 2017

View reviewed changes

jba force-pushed the bq-list-rows branch from a83fea8 to cc9f1ea Compare October 5, 2017 17:17

tswast reviewed Oct 5, 2017

View reviewed changes

bigquery: add Client.list_rows, remove Table.fetch_data

8098482

jba force-pushed the bq-list-rows branch from cc9f1ea to 8098482 Compare October 6, 2017 00:27

tswast approved these changes Oct 6, 2017

View reviewed changes

jba merged commit 7e2f538 into googleapis:bigquery-b2 Oct 6, 2017

tswast pushed a commit that referenced this pull request Oct 12, 2017

bigquery: add Client.list_rows, remove Table.fetch_data (#4119)

ccf0ec2

tswast pushed a commit that referenced this pull request Oct 16, 2017

bigquery: add Client.list_rows, remove Table.fetch_data (#4119)

3a99312

Conversation

jba commented Oct 4, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants