Sync mtime with updated time #468

grapefruit623 · 2014-12-28T15:03:54Z

For issue #311
storage.key.get_contents_to_filename will sync file's mtime and metadata's updated time

gcloud/storage/key.py

coveralls · 2014-12-29T15:20:33Z

Coverage remained the same when pulling e794ec4 on grapefruit623:issue311 into b343acf on GoogleCloudPlatform:master.

dhermes · 2014-12-30T02:51:14Z

@grapefruit623 I think it's bad form to have 4 commits for such a small change; it certainly makes the history filled with noise. Would you mind re-writing the history in your branch? I'm happy to help if you're having issues.

As for the change, it seems just fine but I don't feel like I understand reasons not to do this / behavior in other libraries like boto or even behavior via the gsutil CLI tool (now gcloud). Do you know the broader context?

tseaver · 2014-12-31T21:50:27Z

@grapefruit623 can you please sign the CLA, as described in CONTRIBUTING.

coveralls · 2015-01-01T15:59:21Z

Coverage remained the same when pulling c25a6e7 on grapefruit623:issue311 into b79d862 on GoogleCloudPlatform:master.

grapefruit623 · 2015-01-01T16:03:53Z

Hello, I modified my git commit to one commit so it look like clear.
By the way I have signed the CLA.

tseaver · 2015-01-01T17:30:26Z

Thanks, LGTM. @silvolu, can you please confirm the CLA?

silvolu · 2015-01-05T19:27:03Z

CLA signed.

dhermes · 2015-01-07T19:08:16Z

We are good to merge this?

Sync mtime with updated time

Source-Link: googleapis/synthtool@5f2a608 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…e dump (#468) * feat: add support for new ImportEntries() API, including format of the dump feat: add support for entries associated with Looker and CloudSQL feat: add support for a ReconcileTags() API method PiperOrigin-RevId: 516484690 Source-Link: googleapis/googleapis@50eef0f Source-Link: googleapis/googleapis-gen@09b2058 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliMjA1ODE5YWE2ZDgyMzkzZWY4NjViNTk2NTcxODE0YzVkMTg0MCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Delete sync-repo-settings to use the default required checks --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…468)

* chore: upgrade gapic-generator-java, gax-java and gapic-generator-python PiperOrigin-RevId: 423842556 Source-Link: googleapis/googleapis@a616ca0 Source-Link: googleapis/googleapis-gen@29b938c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjliOTM4YzU4YzFlNTFkMDE5ZjJlZTUzOWQ1NWRjMGEzYzg2YTkwNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(samples): deleting migrated samples * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

fix(deps): require proto-plus >= 1.22.0

Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790

* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * require python 3.7+ in setup.py * remove python 3.6 sample configs Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Release-Please tags release in the format `v1.2.3`.

* chore(python): use python 3.10 for docs build Source-Link: googleapis/synthtool@9ae0785 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:52210e0e0559f5ea8c52be148b33504022e1faef4e95fbe4b32d68022af2fa7e * use python 3.10 for docs build --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * require python 3.7+ in setup.py * remove python 3.6 sample configs * exclude templated README * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update python_requires in setup.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…468) Source-Link: googleapis/synthtool@280ddae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:346ab2efb51649c5dde7756cbbdc60dd394852ba83b9bbffc292a63549f33c17 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…le (#468) Source-Link: googleapis/synthtool@a7ed11e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafcc Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

`tests/__init__.py` has been removed, making `tests` just a folder, not a Python package. This will prevent the installation of a `tests` top-level package as a side effect of installing NDB. Fixes #468.

Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

dhermes reviewed Dec 28, 2014
View reviewed changes

gcloud/storage/key.py Outdated

This comment was marked as spam.

Sign in to view

silvolu added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 31, 2014

Sync mtime with updated time

c25a6e7

grapefruit623 force-pushed the issue311 branch from e794ec4 to c25a6e7 Compare January 1, 2015 15:57

silvolu added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 5, 2015

tseaver added a commit that referenced this pull request Jan 8, 2015

Merge pull request #468 from grapefruit623/issue311

549c175

Sync mtime with updated time

tseaver merged commit 549c175 into googleapis:master Jan 8, 2015

dhermes mentioned this pull request Jan 13, 2015

storage.Key.get_contents_to_filename: sync mtime with 'updated' time from metadata #311

Closed

grapefruit623 deleted the issue311 branch January 17, 2015 08:12

parthea pushed a commit that referenced this pull request Aug 15, 2023

chore(deps): update dependency google-cloud-dialogflow-cx to v1.13.5 (#…

3d1daf2

…468)

parthea added a commit that referenced this pull request Sep 22, 2023

chore(deps): update all dependencies (#468)

82f9f03

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.13.5 (#468)

0bbb2ed

parthea added a commit that referenced this pull request Oct 21, 2023

fix(deps): allow protobuf < 5.0.0 (#468)

aa4ef4b

fix(deps): require proto-plus >= 1.22.0

parthea pushed a commit that referenced this pull request Nov 24, 2025

build: adjust regex for tags (#468)

fd19e1f

Release-Please tags release in the format `v1.2.3`.

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 2.11.0 (#468)

e0e568f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(main): release 2.17.0 (#468)

174e059

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sync mtime with updated time #468

Sync mtime with updated time #468

Uh oh!

grapefruit623 commented Dec 28, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Dec 29, 2014

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

coveralls commented Jan 1, 2015

Uh oh!

grapefruit623 commented Jan 1, 2015

Uh oh!

tseaver commented Jan 1, 2015

Uh oh!

silvolu commented Jan 5, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sync mtime with updated time #468

Sync mtime with updated time #468

Uh oh!

Conversation

grapefruit623 commented Dec 28, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Dec 29, 2014

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

coveralls commented Jan 1, 2015

Uh oh!

grapefruit623 commented Jan 1, 2015

Uh oh!

tseaver commented Jan 1, 2015

Uh oh!

silvolu commented Jan 5, 2015

Uh oh!

dhermes commented Jan 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants