Skip to content

[DNS] Ensure that ManagedZone:exists() does not misreport True result. #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 1 commit into from
Dec 14, 2018
Merged

[DNS] Ensure that ManagedZone:exists() does not misreport True result. #6884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dns/google/cloud/dns/zone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,7 @@ def exists(self, client=None):
client = self._require_client(client)

try:
client._connection.api_request(
method="GET", path=self.path, query_params={"fields": "id"}
)
client._connection.api_request(method="GET", path=self.path)
except NotFound:
return False
else:
Expand Down
2 changes: 0 additions & 2 deletions dns/tests/unit/test_zone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,6 @@ def test_exists_miss_w_bound_client(self):
req = conn._requested[0]
self.assertEqual(req["method"], "GET")
self.assertEqual(req["path"], "/%s" % PATH)
self.assertEqual(req["query_params"], {"fields": "id"})

def test_exists_hit_w_alternate_client(self):
PATH = "projects/%s/managedZones/%s" % (self.PROJECT, self.ZONE_NAME)
Expand All @@ -347,7 +346,6 @@ def test_exists_hit_w_alternate_client(self):
req = conn2._requested[0]
self.assertEqual(req["method"], "GET")
self.assertEqual(req["path"], "/%s" % PATH)
self.assertEqual(req["query_params"], {"fields": "id"})

def test_reload_w_bound_client(self):
PATH = "projects/%s/managedZones/%s" % (self.PROJECT, self.ZONE_NAME)
Expand Down