Asset: remove unused message exports (via synth).#7262
Asset: remove unused message exports (via synth).#7262yoshi-automation wants to merge 1 commit intomasterfrom
Conversation
…t library generator.
tseaver
left a comment
There was a problem hiding this comment.
@crwilcox This looks like a change to gapic-generator, as the underlying .proto files have not changed. While nothing in our code depends on having the shared messages exported from google.asset_v1beta1.types, this kind of change might be breaking for users?
|
BigQuery systest failure due to #7300 (unrelated to this PR). |
|
Bigtable failures due to #7003 (unrelated). |
|
Asset test failures are troubling: Running session unit-3.5
Creating virtualenv using python3.5 in /tmpfs/src/github/google-cloud-python/asset/.nox/unit-3-5
pip install --upgrade mock pytest pytest-cov
pip install --upgrade -e ../api_core
pip install --upgrade -e ../core
pip install --upgrade -e .
py.test --quiet --cov=google.cloud --cov=tests.unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=79 tests/unit
.... [100%]Coverage.py warning: Module google.cloud was previously imported, but not measured (module-not-measured)
Coverage.py warning: Module tests.unit was never imported. (module-not-imported)
FAIL Required test coverage of 79% not reached. Total coverage: 78.43%I cannot reproduce on my local machine, although I do see the coverage warnings during the unit test runs, and the same missing coverage lines in |
|
@crwilcox I just checked, and putting the three unused imports back does get the coverage back above the required 79% / 80 % thressholds, which has to be bogus. |
|
Closing this to force a regen. |
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: