Skip to content

fix(speech): move 'speaker_tag' field from 'SpeakerDiarizationConfig' to 'WordInfo' (via synth) #9576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 1 commit into from
Oct 31, 2019
Merged

fix(speech): move 'speaker_tag' field from 'SpeakerDiarizationConfig' to 'WordInfo' (via synth) #9576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions speech/google/cloud/speech_v1/proto/cloud_speech.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,14 +366,6 @@ message SpeakerDiarizationConfig {
// flexibility by allowing the system to automatically determine the correct
// number of speakers. If not set, the default value is 6.
int32 max_speaker_count = 3;

// A distinct integer value is assigned for every speaker within
// the audio. This field specifies which one of those speakers was detected to
// have spoken this word. Value ranges from '1' to diarization_speaker_count.
// speaker_tag is set if enable_speaker_diarization = 'true' and only in the
// top alternative.
int32 speaker_tag = 5
[(google.api.field_behavior) = OUTPUT_ONLY];
}

// Description of audio data to be recognized.
Expand Down Expand Up @@ -752,4 +744,12 @@ message WordInfo {

// The word corresponding to this set of information.
string word = 3;

// A distinct integer value is assigned for every speaker within
// the audio. This field specifies which one of those speakers was detected to
// have spoken this word. Value ranges from '1' to diarization_speaker_count.
// speaker_tag is set if enable_speaker_diarization = 'true' and only in the
// top alternative.
int32 speaker_tag = 5
[(google.api.field_behavior) = OUTPUT_ONLY];
}
Copy link
Contributor

@tseaver tseaver Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially a breaking change, although it looks obviously correct (the unchanged docstring implies that the speaker_tag should always have been associated with a word).

The field was added to SpeakerDiarizationConfig on 2019-09-24, which is later than any release of google-cloud-speech, so I think we can let it slide.

Copy link
Contributor

@busunkim96 busunkim96 Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be reverted tomorrow given discussions in the Yoshi chatroom. Will be keeping an eye on it.

Loading