Skip to content

fix(automl): fix uploading pandas dataframe to AutoML Tables #9647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helinwang merged 1 commit into from
Nov 12, 2019
Merged

fix(automl): fix uploading pandas dataframe to AutoML Tables #9647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion automl/google/cloud/automl_v1beta1/tables/gcs_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,12 @@ def upload_pandas_dataframe(self, dataframe, uploaded_csv_name=None):
uploaded_csv_name = "automl-tables-dataframe-{}.csv".format(
int(time.time())
)
csv_string = dataframe.to_csv()

# Setting index to False to ignore exporting the data index:
# 1. The resulting column name for the index column is empty, AutoML
# Tables does not allow empty column name
# 2. The index is not an useful training information
csv_string = dataframe.to_csv(index=False)

bucket = self.client.get_bucket(self.bucket_name)
blob = bucket.blob(uploaded_csv_name)
Expand Down
4 changes: 2 additions & 2 deletions automl/tests/unit/gapic/v1beta1/test_gcs_client_v1beta1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def test_upload_pandas_dataframe(self):

gcs_client.client.get_bucket.assert_called_with("my-bucket")
mock_bucket.blob.assert_called_with("my-file.csv")
mock_blob.upload_from_string.assert_called_with(",col1,col2\n0,1,3\n1,2,4\n")
mock_blob.upload_from_string.assert_called_with("col1,col2\n1,3\n2,4\n")
assert gcs_uri == "gs://my-bucket/my-file.csv"

def test_upload_pandas_dataframe_no_csv_name(self):
Expand All @@ -156,7 +156,7 @@ def test_upload_pandas_dataframe_no_csv_name(self):

gcs_client.client.get_bucket.assert_called_with("my-bucket")
mock_bucket.blob.assert_called_with(generated_csv_name)
mock_blob.upload_from_string.assert_called_with(",col1,col2\n0,1,3\n1,2,4\n")
mock_blob.upload_from_string.assert_called_with("col1,col2\n1,3\n2,4\n")
assert re.match("^gs://my-bucket/automl-tables-dataframe-[0-9]*.csv$", gcs_uri)

def test_upload_pandas_dataframe_not_type_dataframe(self):
Expand Down