tests(videointelligence): normalize VPCSC configuration in systests

videointelligence/noxfile.py

@@ -118,19 +118,12 @@ def system(session):
     session.install("-e", "../test_utils/")
     session.install("-e", ".")
 
-    # Additional set up for VPC SC.
-    env = {
-        "PROJECT_NUMBER": "570941833855",
-        "GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_IP": "10.1.1.1",
-        "GOOGLE_CLOUD_TESTS_VPCSC_INSIDE_IP": "55.55.0.0",
-    }
     # Run py.test against the system tests.
     if system_test_exists:
-        session.run("py.test", "--quiet", system_test_path, env=env, *session.posargs)
+        session.run("py.test", "--quiet", system_test_path, *session.posargs)
+
     if system_test_folder_exists:
-        session.run(
-            "py.test", "--quiet", system_test_folder_path, env=env * session.posargs
-        )
+        session.run("py.test", "--quiet", system_test_folder_path, *session.posargs)
 
 
 @nox.session(python="3.7")

videointelligence/tests/system/test_system.py

@@ -0,0 +1,41 @@
+# Copyright 2019, Google LLC All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""System tests for VideoIntelligence API."""
+
+import pytest
+
+from google.cloud import videointelligence_v1
+from test_utils.retry import RetryResult
+
+
+INPUT_URI = "gs://cloud-samples-data/video/cat.mp4"
+
+
+@pytest.fixture(scope="module")
+def client():
+    return videointelligence_v1.VideoIntelligenceServiceClient()
+
+
+def test_annotate_video(client):
+    features_element = videointelligence_v1.enums.Feature.LABEL_DETECTION
+    features = [features_element]
+    response = client.annotate_video(input_uri=INPUT_URI, features=features)
+
+    retry = RetryResult(result_predicate=bool, max_tries=7)
+    retry(response.done)()
+
+    result = response.result()
+    annotations = result.annotation_results[0]
+    assert len(annotations.segment_label_annotations) > 0

videointelligence/tests/system/test_vpcsc.py

@@ -0,0 +1,81 @@
+# Copyright 2017, Google LLC All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+"""Verify videointelligence requests are blocked by VPCSC policy."""
+
+import json
+import os
+import requests
+
+from google.auth.transport import requests as goog_auth_requests
+from google.oauth2 import service_account
+import pytest
+
+from test_utils.vpcsc_config import vpcsc_config
+
+CLOUD_PLATFORM_SCOPE = "https://www.googleapis.com/auth/cloud-platform"
+CREDENTIALS_FILE = os.environ.get("GOOGLE_APPLICATION_CREDENTIALS")
+API_ENDPOINT_URL = "https://videointelligence.googleapis.com/v1/videos:annotate"
+
+
+@pytest.fixture(scope="module")
+def access_token():
+    """Generate access token using the provided service account key file."""
+    creds = service_account.Credentials.from_service_account_file(
+        CREDENTIALS_FILE, scopes=[CLOUD_PLATFORM_SCOPE]
+    )
+    with requests.Session() as session:
+        creds.refresh(goog_auth_requests.Request(session=session))
+
+    return creds.token
+
+
+@pytest.fixture(scope="module")
+def headers(access_token):
+    return {
+        "Authorization": "Bearer " + access_token,
+        "Content-Type": "application/json",
+    }
+
+
+def _make_body(bucket_name):
+    return json.dumps(
+        {
+            "features": ["LABEL_DETECTION"],
+            "location_id": "us-west1",
+            "input_uri": "gs://{}/cat.mp4".format(bucket_name),
+        }
+    )
+
+
+@vpcsc_config.skip_unless_inside_vpcsc
+def test_outside_perimeter_blocked(headers):
+    body = _make_body(bucket_name=vpcsc_config.bucket_outside)
+
+    response = requests.post(url=API_ENDPOINT_URL, data=body, headers=headers)
+
+    assert response.json["error"]["code"] == 403
+    assert response.json["error"]["status"] == "PERMISSION_DENIED"
+
+
+@vpcsc_config.skip_unless_inside_vpcsc
+def test_inside_perimeter_allowed(headers):
+    body = _make_body(bucket_name=vpcsc_config.inside_bucket)
+
+    response = requests.post(url=API_ENDPOINT_URL, data=body, headers=headers)
+
+    operation = response.json
+    op_url = "https://videointelligence.googleapis.com/v1/{}".format(operation["name"])
+    op_response = requests.get(url=op_url, headers=headers)
+    # Assert that we do not get an error.
+    assert op_response.json["name"] == operation["name"]