Skip to content

fix(bigquery_datatransfer): deprecate resource name helper methods (via synth) #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 1 commit into from
Dec 23, 2019
Merged

fix(bigquery_datatransfer): deprecate resource name helper methods (via synth) #9829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 48 additions & 8 deletions ..._datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):

@classmethod
def location_path(cls, project, location):
"""Return a fully-qualified location string."""
"""DEPRECATED. Return a fully-qualified location string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}",
project=project,
Expand All @@ -99,7 +104,12 @@ def location_path(cls, project, location):

@classmethod
def location_data_source_path(cls, project, location, data_source):
"""Return a fully-qualified location_data_source string."""
"""DEPRECATED. Return a fully-qualified location_data_source string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/dataSources/{data_source}",
project=project,
Expand All @@ -109,7 +119,12 @@ def location_data_source_path(cls, project, location, data_source):

@classmethod
def location_run_path(cls, project, location, transfer_config, run):
"""Return a fully-qualified location_run string."""
"""DEPRECATED. Return a fully-qualified location_run string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/transferConfigs/{transfer_config}/runs/{run}",
project=project,
Expand All @@ -120,7 +135,12 @@ def location_run_path(cls, project, location, transfer_config, run):

@classmethod
def location_transfer_config_path(cls, project, location, transfer_config):
"""Return a fully-qualified location_transfer_config string."""
"""DEPRECATED. Return a fully-qualified location_transfer_config string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/transferConfigs/{transfer_config}",
project=project,
Expand All @@ -130,14 +150,24 @@ def location_transfer_config_path(cls, project, location, transfer_config):

@classmethod
def project_path(cls, project):
"""Return a fully-qualified project string."""
"""DEPRECATED. Return a fully-qualified project string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}", project=project
)

@classmethod
def project_data_source_path(cls, project, data_source):
"""Return a fully-qualified project_data_source string."""
"""DEPRECATED. Return a fully-qualified project_data_source string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/dataSources/{data_source}",
project=project,
Expand All @@ -146,7 +176,12 @@ def project_data_source_path(cls, project, data_source):

@classmethod
def project_run_path(cls, project, transfer_config, run):
"""Return a fully-qualified project_run string."""
"""DEPRECATED. Return a fully-qualified project_run string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/transferConfigs/{transfer_config}/runs/{run}",
project=project,
Expand All @@ -156,7 +191,12 @@ def project_run_path(cls, project, transfer_config, run):

@classmethod
def project_transfer_config_path(cls, project, transfer_config):
"""Return a fully-qualified project_transfer_config string."""
"""DEPRECATED. Return a fully-qualified project_transfer_config string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/transferConfigs/{transfer_config}",
project=project,
Expand Down
10 changes: 5 additions & 5 deletions bigquery_datatransfer/synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-11-12T13:16:39.771005Z",
"updateTime": "2019-11-19T13:15:31.582050Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.41.1",
"dockerImage": "googleapis/artman@sha256:545c758c76c3f779037aa259023ec3d1ef2d57d2c8cd00a222cb187d63ceac5e"
"version": "0.42.1",
"dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "f69562be0608904932bdcfbc5ad8b9a22d9dceb8",
"internalRef": "279774957"
"sha": "d8dd7fe8d5304f7bd1c52207703d7f27d5328c5a",
"internalRef": "281088257"
}
},
{
Expand Down