Skip to content

fix(vision): deprecate resource name helper methods (via synth) #9866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 1 commit into from
Nov 20, 2019
Merged

fix(vision): deprecate resource name helper methods (via synth) #9866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vision/docs/_static/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
div#python2-eol {
border-color: red;
border-width: medium;
}
}
1 change: 1 addition & 0 deletions vision/docs/_templates/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

{% extends "!layout.html" %}
{%- block content %}
{%- if theme_fixed_sidebar|lower == 'true' %}
Expand Down
28 changes: 24 additions & 4 deletions vision/google/cloud/vision_v1/gapic/product_search_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):

@classmethod
def location_path(cls, project, location):
"""Return a fully-qualified location string."""
"""DEPRECATED. Return a fully-qualified location string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}",
project=project,
Expand All @@ -105,7 +110,12 @@ def location_path(cls, project, location):

@classmethod
def product_path(cls, project, location, product):
"""Return a fully-qualified product string."""
"""DEPRECATED. Return a fully-qualified product string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/products/{product}",
project=project,
Expand All @@ -115,7 +125,12 @@ def product_path(cls, project, location, product):

@classmethod
def product_set_path(cls, project, location, product_set):
"""Return a fully-qualified product_set string."""
"""DEPRECATED. Return a fully-qualified product_set string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/productSets/{product_set}",
project=project,
Expand All @@ -125,7 +140,12 @@ def product_set_path(cls, project, location, product_set):

@classmethod
def reference_image_path(cls, project, location, product, reference_image):
"""Return a fully-qualified reference_image string."""
"""DEPRECATED. Return a fully-qualified reference_image string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/products/{product}/referenceImages/{reference_image}",
project=project,
Expand Down
28 changes: 24 additions & 4 deletions vision/google/cloud/vision_v1p3beta1/gapic/product_search_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):

@classmethod
def location_path(cls, project, location):
"""Return a fully-qualified location string."""
"""DEPRECATED. Return a fully-qualified location string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}",
project=project,
Expand All @@ -102,7 +107,12 @@ def location_path(cls, project, location):

@classmethod
def product_path(cls, project, location, product):
"""Return a fully-qualified product string."""
"""DEPRECATED. Return a fully-qualified product string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/products/{product}",
project=project,
Expand All @@ -112,7 +122,12 @@ def product_path(cls, project, location, product):

@classmethod
def product_set_path(cls, project, location, product_set):
"""Return a fully-qualified product_set string."""
"""DEPRECATED. Return a fully-qualified product_set string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/productSets/{product_set}",
project=project,
Expand All @@ -122,7 +137,12 @@ def product_set_path(cls, project, location, product_set):

@classmethod
def reference_image_path(cls, project, location, product, reference_image):
"""Return a fully-qualified reference_image string."""
"""DEPRECATED. Return a fully-qualified reference_image string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/products/{product}/referenceImages/{reference_image}",
project=project,
Expand Down
28 changes: 24 additions & 4 deletions vision/google/cloud/vision_v1p4beta1/gapic/product_search_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):

@classmethod
def location_path(cls, project, location):
"""Return a fully-qualified location string."""
"""DEPRECATED. Return a fully-qualified location string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}",
project=project,
Expand All @@ -103,7 +108,12 @@ def location_path(cls, project, location):

@classmethod
def product_path(cls, project, location, product):
"""Return a fully-qualified product string."""
"""DEPRECATED. Return a fully-qualified product string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/products/{product}",
project=project,
Expand All @@ -113,7 +123,12 @@ def product_path(cls, project, location, product):

@classmethod
def product_set_path(cls, project, location, product_set):
"""Return a fully-qualified product_set string."""
"""DEPRECATED. Return a fully-qualified product_set string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/productSets/{product_set}",
project=project,
Expand All @@ -123,7 +138,12 @@ def product_set_path(cls, project, location, product_set):

@classmethod
def reference_image_path(cls, project, location, product, reference_image):
"""Return a fully-qualified reference_image string."""
"""DEPRECATED. Return a fully-qualified reference_image string."""
warnings.warn(
"Resource name helper functions are deprecated.",
PendingDeprecationWarning,
stacklevel=1,
)
return google.api_core.path_template.expand(
"projects/{project}/locations/{location}/products/{product}/referenceImages/{reference_image}",
project=project,
Expand Down
10 changes: 5 additions & 5 deletions vision/synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-11-06T13:44:16.072107Z",
"updateTime": "2019-11-20T13:38:24.545550Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.41.0",
"dockerImage": "googleapis/artman@sha256:75b38a3b073a7b243545f2332463096624c802bb1e56b8cb6f22ba1ecd325fa9"
"version": "0.42.1",
"dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "5691fcb7c1a926b52577aa1834f31d9c50efda54",
"internalRef": "278731899"
"sha": "16543773103e2619d2b5f52456264de5bb9be104",
"internalRef": "281423227"
}
},
{
Expand Down