Update GoogleAuth #105
Merged
Update GoogleAuth #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look for the default application credentials file. This file is created by the gcloud application.
File.file? ensures that the path is a file, while File.exist? will return true for a directory.
The logic to determine default credenitals is about to become more complex. This new method will be where the heavy lifting will take place.
The googleauth library is now used by google_api_client, and it supports resolving the application default settings from ENV and from GCE.
blowmage
added a commit
that referenced
this pull request
Mar 24, 2015
Add support for the Cloud SDK's credential application file as well as Google Compute Engine. [Closes #102]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the Cloud SDK's credential application file as well as Google Compute Engine.
[Resolves #102]