Performance: JsonHttpContent.writeTo() is called twice for each HttpRequest

[siom79]

Debugging shows that the method JsonHttpContent.writeTo() is called twice when a HttpRequest is rendered. For the first time it is called to compute the length of the body and for the second time to actually render the JSON string.

First invocation:

"main@1" prio=5 tid=0x1 nid=NA runnable
  java.lang.Thread.State: RUNNABLE
      at com.google.api.client.http.json.JsonHttpContent.writeTo(JsonHttpContent.java:73)
      at com.google.api.client.util.IOUtils.computeLength(IOUtils.java:113)
      at com.google.api.client.http.AbstractHttpContent.computeLength(AbstractHttpContent.java:139)
      at com.google.api.client.http.AbstractHttpContent.computeLength(AbstractHttpContent.java:117)
      at com.google.api.client.http.AbstractHttpContent.getLength(AbstractHttpContent.java:65)
      at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:914)

Second invocation:

"main@1" prio=5 tid=0x1 nid=NA runnable
  java.lang.Thread.State: RUNNABLE
      at com.google.api.client.http.json.JsonHttpContent.writeTo(JsonHttpContent.java:73)
      at com.google.api.client.http.javanet.NetHttpRequest.execute(NetHttpRequest.java:79)
      at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:965)

[andrey-qlogic]

@siom79 , @ajaaym This is not either a bug and a feature. I don't think that a code change is required for this request. That code of the method public long getLength() throws IOException

works as expected. It calls the second method only once when contentLength is -1.

[andrey-qlogic]

@siom79, @ajaaym , @sduskis Please ignore my comment above.
It calls twice here

google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java

Line 1012 in 8217035

contentLength = content.getLength();

and here

google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java

Line 1076 in 8217035

LowLevelHttpResponse lowLevelHttpResponse = lowLevelHttpRequest.execute();

because we need to calculate a Content-Length. Assume we could drop Content-Length when the length is known but it may not work then for example for retry requests.

[andrey-qlogic]

@ejona86, @JustinBeckwith is the feature request still actual? by the log above I'm not clear about.

[sduskis]

@andrey-qlogic, yo usaw that the code gets called twice. We should fix that.

[elharo]

I think #910 fixed this. Reopen if not.