Skip to content

feat!: update dependency com.google.cloud:google-cloud-shared-config to v1 #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 5 commits into from
Aug 5, 2021
Merged

feat!: update dependency com.google.cloud:google-cloud-shared-config to v1 #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa3879e
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
renovate-bot Jul 29, 2021
5819430
chore: update declaration of some test types to accommodate new java8…
BenWhitehead Aug 4, 2021
f59cbc0
chore: run :format
BenWhitehead Aug 4, 2021
301b669
fix broken IT
stephaniewang526 Aug 5, 2021
984f6f4
fix lint
stephaniewang526 Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/JobStatisticsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,26 +322,31 @@ public void testIncomplete() {
new com.google.api.services.bigquery.model.JobStatistics()
.setCreationTime(1234L)
.setStartTime(5678L));
JobStatistics jobStatistics;

job.setConfiguration(
new com.google.api.services.bigquery.model.JobConfiguration()
.setCopy(new com.google.api.services.bigquery.model.JobConfigurationTableCopy()));
assertThat(JobStatistics.fromPb(job)).isInstanceOf(CopyStatistics.class);
jobStatistics = JobStatistics.fromPb(job);
assertThat(jobStatistics).isInstanceOf(CopyStatistics.class);

job.setConfiguration(
new com.google.api.services.bigquery.model.JobConfiguration()
.setLoad(new com.google.api.services.bigquery.model.JobConfigurationLoad()));
assertThat(JobStatistics.fromPb(job)).isInstanceOf(LoadStatistics.class);
jobStatistics = JobStatistics.fromPb(job);
assertThat(jobStatistics).isInstanceOf(LoadStatistics.class);

job.setConfiguration(
new com.google.api.services.bigquery.model.JobConfiguration()
.setExtract(new com.google.api.services.bigquery.model.JobConfigurationExtract()));
assertThat(JobStatistics.fromPb(job)).isInstanceOf(ExtractStatistics.class);
jobStatistics = JobStatistics.fromPb(job);
assertThat(jobStatistics).isInstanceOf(ExtractStatistics.class);

job.setConfiguration(
new com.google.api.services.bigquery.model.JobConfiguration()
.setQuery(new com.google.api.services.bigquery.model.JobConfigurationQuery()));
assertThat(JobStatistics.fromPb(job)).isInstanceOf(QueryStatistics.class);
jobStatistics = JobStatistics.fromPb(job);
assertThat(jobStatistics).isInstanceOf(QueryStatistics.class);
}

private void compareExtractStatistics(ExtractStatistics expected, ExtractStatistics value) {
Expand Down
18 changes: 6 additions & 12 deletions google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,11 +1202,9 @@ public void testUpdateTimePartitioning() {
.build();

Table table = bigquery.create(TableInfo.of(tableId, tableDefinition));
assertThat(table.getDefinition()).isInstanceOf(StandardTableDefinition.class);
assertThat(
((StandardTableDefinition) table.getDefinition())
.getTimePartitioning()
.getExpirationMs())
TableDefinition definition = table.getDefinition();
assertThat(definition).isInstanceOf(StandardTableDefinition.class);
assertThat(((StandardTableDefinition) definition).getTimePartitioning().getExpirationMs())
.isNull();

table =
Expand All @@ -1219,10 +1217,9 @@ public void testUpdateTimePartitioning() {
.build())
.build()
.update(BigQuery.TableOption.fields(BigQuery.TableField.TIME_PARTITIONING));
TableDefinition updatedDefinition = table.getDefinition();
assertThat(
((StandardTableDefinition) table.getDefinition())
.getTimePartitioning()
.getExpirationMs())
((StandardTableDefinition) updatedDefinition).getTimePartitioning().getExpirationMs())
.isEqualTo(42L);

table =
Expand All @@ -1235,10 +1232,7 @@ public void testUpdateTimePartitioning() {
.build())
.build()
.update(BigQuery.TableOption.fields(BigQuery.TableField.TIME_PARTITIONING));
assertThat(
((StandardTableDefinition) table.getDefinition())
.getTimePartitioning()
.getExpirationMs())
assertThat(((StandardTableDefinition) definition).getTimePartitioning().getExpirationMs())
.isNull();

table.delete();
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-shared-config</artifactId>
<version>0.13.1</version>
<version>1.0.0</version>
</parent>

<developers>
Expand Down