Skip to content

fix: Job.isDone() uses Job.Status.State if available #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nbali wants to merge 2 commits into from
Closed

fix: Job.isDone() uses Job.Status.State if available #3673

nbali wants to merge 2 commits into from

Conversation

@nbali
Copy link

@nbali nbali commented Feb 12, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3672 ☕️

If you write sample code, please follow the samples format.

@nbali
googleapis#3672 Using in-memory Job.Status.State - if present - for J…
e9826fc 
…ob.isDone() calls first to avoid remote calls
@nbali nbali requested a review from a team as a code owner February 12, 2025 13:50
@nbali nbali requested a review from Linchin February 12, 2025 13:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Feb 12, 2025
@PhongChuong
Copy link
Contributor

PhongChuong commented Feb 13, 2025

Thanks for the issue/fix.
PR looks good pending the merge tests.

@PhongChuong PhongChuong self-requested a review February 13, 2025 15:48
@PhongChuong PhongChuong changed the title #3672 Using in-memory Job.Status.State - if present - for Job.isDone() calls first to avoid remote calls fix: Job.isDone() uses Job.Status.State if available Feb 18, 2025
@AbgarSim AbgarSim mentioned this pull request Dec 18, 2025
Merged
4 tasks
@lqiu96
Copy link
Member

lqiu96 commented Dec 19, 2025

Thanks for the original implementation. Addressed in #4039

@lqiu96 lqiu96 closed this Dec 19, 2025
@nbali nbali deleted the fix_for_3672 branch January 7, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhongChuong PhongChuong PhongChuong left review comments

@Linchin Linchin Awaiting requested review from Linchin Linchin is a code owner automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Potentially unnecessary bigquery.getJob() calls in Job.isDone()

3 participants

@nbali @PhongChuong @lqiu96