-
Notifications
You must be signed in to change notification settings - Fork 131
chore(deps): update dependency com.google.cloud:libraries-bom to v26.74.0 #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update dependency com.google.cloud:libraries-bom to v26.74.0 #4070
Conversation
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Google Cloud Libraries Bill of Materials (BOM) to its latest stable version. This ensures that the project benefits from the most recent bug fixes, performance enhancements, and new features across various Google Cloud client libraries, maintaining compatibility and leveraging the latest improvements provided by Google. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the com.google.cloud:libraries-bom dependency to version 26.74.0. The update is straightforward and helps keep dependencies current. During the review, I identified a related issue in samples/snippets/pom.xml where a dependency, google-cloud-bigtable, has a hardcoded version. This practice overrides the version managed by the BOM and can lead to inconsistencies. With this update, the hardcoded version is now older than the one provided by the new BOM. I've left a comment on the relevant change with more details. It would be beneficial to address this in a follow-up to ensure consistent dependency management.
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>libraries-bom</artifactId> | ||
| <version>26.73.0</version> | ||
| <version>26.74.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this BOM update is beneficial, it highlights a pre-existing dependency management issue within this file. The google-cloud-bigtable dependency (lines 110-115) has its version hardcoded to 2.62.0. This new libraries-bom version 26.74.0 provides google-cloud-bigtable at version 2.71.0.
Pinning the version overrides the version provided by the BOM, which can lead to dependency conflicts and negates the purpose of using a BOM. It is recommended to remove the <version>2.62.0</version> line for google-cloud-bigtable to allow the BOM to manage its version. This should be addressed in a follow-up change.
This PR contains the following updates:
26.73.0→26.74.0Release Notes
googleapis/java-cloud-bom (com.google.cloud:libraries-bom)
v26.74.0Dependencies
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.