Merged
Conversation
suztomo
approved these changes
Nov 8, 2022
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-text</artifactId> | ||
| <version>${apache.commons-text.version}</version> |
Member
There was a problem hiding this comment.
I wondered Guava can do the same job but it seems not https://stackoverflow.com/questions/34091304/does-guava-provide-a-method-to-unescape-a-string
suztomo
reviewed
Nov 8, 2022
| <apache.commons-lang.version>3.12.0</apache.commons-lang.version> | ||
| <apache.commons-collections.version>4.4</apache.commons-collections.version> | ||
| <apache.commons-io.version>2.11.0</apache.commons-io.version> | ||
| <apache.commons-text.version>1.10.0</apache.commons-text.version> |
Member
There was a problem hiding this comment.
This version is safe. But commons text is often marked as CVEs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161
This is the new
...Field.Builder.ymlfile:Issue seems to be from
bodyItem.toString()(https://www.javadoc.io/static/org.kohsuke.sorcerer/sorcerer-javac/0.11/com/sun/tools/javac/tree/DCTree.DCText.html) which renders the with unicode escapes. Use apache-commons-text to render the unicode escapes back to unicode values.