Skip to content

fix: switch from Groovy to Kotlin for Gradle build BOM dependency sam… #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinseopkim0 merged 1 commit into from
Nov 21, 2024
Merged

fix: switch from Groovy to Kotlin for Gradle build BOM dependency sam… #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions third_party/docfx-doclet-143274/src/main/java/com/microsoft/model/LibraryOverviewFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,12 @@ public LibraryOverviewFile(
+ repoMetadata.getArtifactId()
+ "</code> artifact.\n"
+ "<pre class=\"prettyprint lang-Groovy devsite-click-to-copy\">\n"
+ "implementation platform(&#39;com.google.cloud:libraries-bom:"
+ "implementation(platform(&quot;com.google.cloud:libraries-bom:"
+ librariesBomVersion
+ "&#39;)\n"
+ "implementation &#39;"
+ "&quot;))\n"
+ "implementation(&quot;"
+ repoMetadata.getDistributionName()
+ "&#39;\n"
+ "&quot;)\n"
+ "</pre>\n\n"
+ "The <code>platform</code> and <code>enforcedPlatform</code> keywords supply dependency versions\n"
+ "declared in a BOM. The <code>enforcedPlatform</code> keyword enforces the dependency\n"
Expand Down
4 changes: 2 additions & 2 deletions ...rty/docfx-doclet-143274/src/test/resources/expected-generated-files/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ dependency declarations in the artifact's <code>build.gradle</code> file.

The example below demonstrates how you would import the BOM and include the <code>google-cloud-apikeys</code> artifact.
<pre class="prettyprint lang-Groovy devsite-click-to-copy">
implementation platform(&#39;com.google.cloud:libraries-bom:26.19.0&#39;)
implementation &#39;com.google.cloud:google-cloud-apikeys&#39;
implementation(platform(&quot;com.google.cloud:libraries-bom:26.19.0&quot;))
implementation(&quot;com.google.cloud:google-cloud-apikeys&quot;)
</pre>

The <code>platform</code> and <code>enforcedPlatform</code> keywords supply dependency versions
Expand Down