fix: make StreamableQuery#internalStream package-private to avoid documentation and prevent clirr errors #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duckworth/find-nearest
…duckworth/find-nearest
…va-firestore into markduckworth/find-nearest
…va-firestore into markduckworth/find-nearest
…duckworth/find-nearest
…duckworth/find-nearest
…ocumentation and clirr errors
…duckworth/find-nearest
product-auto-label
bot
added
size: xs
google-cloud-firestore/src/main/java/com/google/cloud/firestore/StreamableQuery.java
Show resolved
Hide resolved
product-auto-label
bot
added
size: s
MarkDuckworth
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tom-andersen
approved these changes
Oct 31, 2024
Contributor
tom-andersen
left a comment
tom-andersen
left a comment
There was a problem hiding this comment.
This aligns with the direction I want to move.
Note: I would have gone further, but in the exact same direction, so LGTM and let's get this merged.
MarkDuckworth
changed the title
MarkDuckworth
changed the title
MarkDuckworth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: make StreamableQuery#internalStream package-private to avoid documentation and prevent clirr errors
Release-As: 3.29.0
END_COMMIT_OVERRIDE