Revert "feat: expose all the methods of notification"#393
Merged
Conversation
This reverts commit 8dfc0cb.
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
============================================
- Coverage 63.61% 63.13% -0.49%
+ Complexity 632 601 -31
============================================
Files 33 32 -1
Lines 5222 5078 -144
Branches 498 481 -17
============================================
- Hits 3322 3206 -116
+ Misses 1730 1708 -22
+ Partials 170 164 -6
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #141
I missed this in review: the surface library shouldn't expose the underlying Google API client object model, specifically line:
https://github.com/athakor/java-storage/blob/300c60459ee91669c20283bcc986737002a9ffb6/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java#L24
Which is used as a return type to CRUD operations:
https://github.com/athakor/java-storage/blob/300c60459ee91669c20283bcc986737002a9ffb6/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java#L3438-L3468