Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: call rowQueue insert callback only if present#1128

Merged
steffnay merged 2 commits intogoogleapis:mainfrom
Pitros:fix/call-cb-if-present
Jun 17, 2022
Merged

fix: call rowQueue insert callback only if present#1128
steffnay merged 2 commits intogoogleapis:mainfrom
Pitros:fix/call-cb-if-present

Conversation

@Pitros
Copy link
Copy Markdown
Contributor

@Pitros Pitros commented Jun 14, 2022

This fixes issue where callback is called even if it's not present.

Issue happens when using table.createInsertStream() and after success/failure callback is being called, but it's not passed in roqQueue.add method.

@Pitros Pitros requested a review from a team as a code owner June 14, 2022 13:53
@Pitros Pitros requested review from a team and gnanda June 14, 2022 13:53
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jun 14, 2022
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 15, 2022
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2022
@steffnay steffnay merged commit 17a0c0d into googleapis:main Jun 17, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 30, 2022
🤖 I have created a release *beep* *boop*
---


## [6.0.1](v6.0.0...v6.0.1) (2022-06-17)


### Bug Fixes

* call rowQueue insert callback only if present ([#1128](#1128)) ([17a0c0d](17a0c0d))
* **deps:** update dependency @google-cloud/paginator to v4 ([#1116](#1116)) ([073abc0](073abc0))
* **deps:** update dependency @google-cloud/storage to v6 ([#1119](#1119)) ([d607e5a](d607e5a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit to googleapis/google-cloud-node that referenced this pull request Feb 3, 2026
🤖 I have created a release *beep* *boop*
---


## [6.0.1](googleapis/nodejs-bigquery@v6.0.0...v6.0.1) (2022-06-17)


### Bug Fixes

* call rowQueue insert callback only if present ([#1128](googleapis/nodejs-bigquery#1128)) ([17a0c0d](googleapis/nodejs-bigquery@17a0c0d))
* **deps:** update dependency @google-cloud/paginator to v4 ([#1116](googleapis/nodejs-bigquery#1116)) ([073abc0](googleapis/nodejs-bigquery@073abc0))
* **deps:** update dependency @google-cloud/storage to v6 ([#1119](googleapis/nodejs-bigquery#1119)) ([d607e5a](googleapis/nodejs-bigquery@d607e5a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants