This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Rename query.toJSON to query.json.#122
Merged
stephenplusplus merged 2 commits intogoogleapis:masterfrom Feb 15, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 1257 1257
=====================================
Hits 1257 1257
Continue to review full report at Codecov.
|
src/database.js
Outdated
| * // Error handling omitted. | ||
| * } | ||
| * | ||
| * const row1 = rows[0]; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
alexander-fenster
approved these changes
Feb 15, 2018
callmehiphop
approved these changes
Feb 15, 2018
Merged
Contributor
|
@stephenplusplus Good call 👍 |
eric4545
reviewed
Mar 5, 2018
|
|
||
| delete reqOpts.toJSON; | ||
| delete reqOpts.toJSONOptions; | ||
| delete reqOpts.json; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR, #94, made a poor choice in variable naming. We haven't released to npm, so we'd like to change the name before it's permanent.
Instead of:
This seems better: