feature: batch queries by callmehiphop · Pull Request #132 · googleapis/nodejs-spanner

callmehiphop · 2018-02-26T23:14:40Z

Tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

samples/batch.js

@@ -0,0 +1,246 @@
+/**
+ * Copyright 2018, Google, Inc.


codecov · 2018-02-26T23:40:29Z

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #132   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     12    +1     
  Lines        1257   1355   +98     
=====================================
+ Hits         1257   1355   +98

Impacted Files	Coverage Δ
src/index.js	`100% <ø> (ø)`	⬆️
src/database.js	`100% <100%> (ø)`	⬆️
src/transaction-request.js	`100% <100%> (ø)`	⬆️
src/batch-transaction.js	`100% <100%> (ø)`
src/codec.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bd63f...fca9c6e. Read the comment docs.

src/batch-transaction.js

+ * @private
+ *
+ * @param {object} config The request config.
+ * @param {function} Callback function.


src/batch-transaction.js

+ * Executes partition in streaming mode.
+ *
+ * @see {@link Transaction#createReadStream} when using {@link ReadPartition}.
+ * @see {@link Transaction#runStream} when using {@link QueryParition}.


src/batch-transaction.js

+ *     });
+ * });
+ */
+BatchTransaction.prototype.executeStream = function(partition) {


src/batch-transaction.js

+ * operation in parallel. Partitions become invalid when the transaction used
+ * to create them is closed.
+ *
+ * @param {ReadRequestOptions} options Configuration object, describing what to


src/batch-transaction.js

+ * @example <caption>include:samples/batch.js</caption>
+ * region_tag:execute_partition
+ */
+BatchTransaction.prototype.execute = function(partition, callback) {


src/batch-transaction.js

+ *     });
+ * });
+ */
+BatchTransaction.prototype.executeStream = function(partition) {


src/database.js

+ * @example <caption>include:samples/batch.js</caption>
+ * region_tag:create_batch_transaction
+ */
+Database.prototype.createBatchTransaction = function(options, callback) {


src/database.js

+ *     - **`labels.env:dev`** The instance's label env has the value dev.
+ *     - **`name:howl labels.env:dev`** The instance's name is howl and it has
+ *       the label env with value dev.
+ * @property {number} [maxApiCalls] Maximum number of API calls to make.


src/batch-transaction.js

+ * @private
+ *
+ * @param {object} config The request config.
+ * @param {function} Callback function.


src/batch-transaction.js

+ * @callback CreateReadPartitionsCallback
+ * @param {?Error} err Request error, if any.
+ * @param {ReadPartition[]} partitions List of read partitions.
+ * @param {object} apiResponse The full API response.


src/batch-transaction.js

+/**
+ * @typedef {array} CreateReadPartitionsResponse
+ * @property {ReadPartition[]} 0 List of read partitions.
+ * @property {object} 1 The full API response.


src/batch-transaction.js

+/**
+ * @typedef {object} ReadPartition
+ * @mixes ReadRequestOptions
+ * @property {string} partitionToken The partition token.


src/batch-transaction.js

+ *
+ * const instance = spanner.instance('my-instance');
+ * const database = instance.database('my-database');
+ * const transaction = database.batchTransaction(identifier);


callmehiphop added the status: do not merge label Feb 26, 2018

callmehiphop requested review from alexander-fenster and stephenplusplus February 26, 2018 23:14

ghost assigned callmehiphop Feb 26, 2018

ghost added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2018

feature: batch queries

afe35cd

alexander-fenster reviewed Feb 26, 2018

View reviewed changes

samples/batch.js

@@ -0,0 +1,246 @@

/**

* Copyright 2018, Google, Inc.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

alexander-fenster approved these changes Feb 26, 2018

View reviewed changes

fix linting errors

df0116e

stephenplusplus reviewed Feb 27, 2018

View reviewed changes

src/batch-transaction.js

* @private

*

* @param {object} config The request config.

* @param {function} Callback function.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed Feb 27, 2018

View reviewed changes

stephenplusplus removed the status: do not merge label Feb 27, 2018

stephenplusplus reviewed Feb 27, 2018

View reviewed changes

callmehiphop added 2 commits February 28, 2018 13:38

fix documentation errors per pr feedback

093a80c

update executeStream example

fca9c6e

stephenplusplus approved these changes Mar 1, 2018

View reviewed changes

stephenplusplus merged commit 2857101 into googleapis:master Mar 1, 2018

ghost removed the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2018

stephenplusplus mentioned this pull request Mar 8, 2018

v1.2.0 #145

Merged

Conversation

callmehiphop commented Feb 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

codecov bot commented Feb 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

callmehiphop commented Feb 26, 2018 •

edited

Loading

codecov bot commented Feb 26, 2018 •

edited

Loading