This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Remove autoCreate for objects that return operations.#133
Merged
stephenplusplus merged 4 commits intogoogleapis:masterfrom Mar 2, 2018
Merged
Remove autoCreate for objects that return operations.#133stephenplusplus merged 4 commits intogoogleapis:masterfrom
stephenplusplus merged 4 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
Please discuss over in #127 if you think this is the wrong solution. |
stephenplusplus
force-pushed
the
spp--127
branch
from
2386e97 to
ef37be4
Compare
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 1355 1393 +38
=====================================
+ Hits 1355 1393 +38
Continue to review full report at Codecov.
|
Contributor
Author
|
@callmehiphop ready for review. |
alexander-fenster
approved these changes
Mar 1, 2018
stephenplusplus
changed the title
ghost
removed
the
cla: yes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127
This adds get-or-create behavior to database.get() and instance.get().