file.delete returns a wrong value when the files doesn't exist

[vicb]

Environment details

• OS: MacOs
• Node.js version: v18.10.0
• npm version: 8.19.2
• @google-cloud/storage version: 6.9.5

Steps to reproduce

Try to delete a file that doesn't exists:

const response = await bucket.file('path/to/no/file').delete({ ignoreNotFound: true });

The response is:

[
  {
    error: {
      code: 404,
      message: 'No such object: airsp/tiles/10/100/601.pbf',
      errors: [Array]
    }
  },
  PassThrough {
    //...
  }
]

The first element of the array should not be here as the response is supposed to be a [r.Response]

nodejs-storage/src/file.ts

Line 1983 in b122e18

delete(options?: DeleteOptions): Promise<[r.Response]>;

[ddelgrosso1]

Hi @vicb thank you for opening this issue. Can you explain further why you think the first element should not be here? The first element is the raw response and the second element is the response body. Both of these adhere to the type of [r.Response].

[vicb]

Thanks @ddelgrosso1 for your quick attention to that bug.

I see

nodejs-storage/src/nodejs-common/service-object.ts

Line 275 in b122e18

delete(options?: DeleteOptions): Promise<[r.Response]>;

with r.Response being (node_modules/teeny-request/build/src/index.d.ts):

export interface Response<T = any> {
    statusCode: number;
    headers: Headers;
    body: T;
    request: Request;
    statusMessage?: string;
}

You can see that

  {
    error: {
      code: 404,
      message: 'No such object: airsp/tiles/10/100/601.pbf',
      errors: [Array]
    }
  },

Does not match that type, i.e. it has no statusCode.

Also if the response is supposed to be a tuple then a [Response, Response] type would be more appropriate.

[ddelgrosso1]

@vicb thank you for clarifying (and nice catch!), I see the problem now. It looks like the first item is actually of type ResponseBody which is set to any. Let me see if there is a decent way to fix this without making signature changes or type changes as these would necessitate a major version bump of the library.

[ddelgrosso1]

Released with 7.0