UnhandledPromiseRejection when deleting an object that doesn't exist in a bucket

[ragrag]

Receiving UnhandledPromiseRejection when deleting an object that doesn't exist in a bucket

  async deleteByName(imageName) {
    try {
      await this.storage
        .bucket('this-or-that')
        .file(imageName)
        .delete();
    } catch (err) {
      throw err;
    }
  }

Calling this method with an object that doesn't exist produces

(node:17744) UnhandledPromiseRejectionWarning: Error: No such object: this-or-that/user5d8f564fc428814550deee2c
    at new ApiError (G:\Projects\nodejs\this-or-that\node_modules\@google-cloud\common\build\src\util.js:60:15)
    at Util.parseHttpRespBody (G:\Projects\nodejs\this-or-that\node_modules\@google-cloud\common\build\src\util.js:195:38)
    at Util.handleResp (G:\Projects\nodejs\this-or-that\node_modules\@google-cloud\common\build\src\util.js:136:117)
    at retryRequest (G:\Projects\nodejs\this-or-that\node_modules\@google-cloud\common\build\src\util.js:431:22)
    at onResponse (G:\Projects\nodejs\this-or-that\node_modules\retry-request\index.js:206:7)
    at G:\Projects\nodejs\this-or-that\node_modules\teeny-request\build\src\index.js:256:13
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:17744) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:17744) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the
Node.js process with a non-zero exit code.

Environment details

• OS: Windows 10 64bit
• Node.js version: 10.16.0
• npm version: 6.9.0
• @google-cloud/storage version: 3.3.0

[bcoe]

@jkwlui seems like something worth digging in to, wasn't sure if we should label as a p1.

[stephenplusplus]

Hey @ragrag 👋. Using the same Storage version, I was able to catch and log the error:

'use strict'

const {Storage} = require('@google-cloud/storage')
const storage = new Storage()
const file = storage.bucket(process.env.BUCKET_NAME).file('non-existent-file')

;(async() => {
  try {
    await file.delete()
  } catch (e) {
    console.log('I caught this!', e.message)
  }
})()

Would you be able to try this out? (Feel free to edit the bucket name directly, or set the BUCKET_NAME environment variable.

My output:

$ node .
I caught this! No such object: stephen-has-a-new-bucket/non-existent-file

[ragrag]

Hello @stephenplusplus,
Thank you for your time, upon checking your code and re-examining mine, seems like the problem was in my code invoking this function without awaiting it so it escapes the catch block.

All works fine now, thank you and sorry for any inconveniences 😅

[stephenplusplus]

No problem, glad to hear it's working!