Skip to content

fix: Common Service: should retry a request failed #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelgrosso1 merged 2 commits into from
Sep 18, 2025
Merged

fix: Common Service: should retry a request failed #2652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a58a3f0
fix: Retry failed requests
thiyaguk09 Sep 17, 2025
476d202
fix: Add comment explaining increased timeout
thiyaguk09 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion system-test/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ describe('Common', () => {
});

it('should retry a request', function (done) {
this.timeout(60 * 1000);
// We've increased the timeout to accommodate the retry backoff strategy.
// The test's retry attempts and the delay between them can exceed the default timeout,
// causing a false negative (test failure due to timeout instead of a logic error).
this.timeout(90 * 1000);

let numRequestAttempts = 0;

Expand Down
Loading