feat: provide a to_dict method #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parallels the `to_json` method. Also adds options to ignore unknown fields during deserializtion.
software-dov
requested review from
arithmetic1728,
busunkim96,
crwilcox and
lukesneeringer
google-cla
bot
added
the
cla: yes
software-dov
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 856 863 +7
Branches 148 149 +1
=========================================
+ Hits 856 863 +7
Continue to review full report at Codecov.
|
arithmetic1728
approved these changes
Oct 19, 2020
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.11.0](https://www.github.com/googleapis/proto-plus-python/compare/v1.10.2...v1.11.0) (2020-10-19) ### Features * provide a to_dict method ([#154](https://www.github.com/googleapis/proto-plus-python/issues/154)) ([ccf903e](https://www.github.com/googleapis/proto-plus-python/commit/ccf903e3cddfcb1ff539e853594b4342914b7d61)), closes [#153](https://www.github.com/googleapis/proto-plus-python/issues/153) [#151](https://www.github.com/googleapis/proto-plus-python/issues/151) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
tswast
reviewed
Oct 20, 2020
| """ | ||
|
|
||
| def __init__(self, mapping=None, **kwargs): | ||
| def __init__(self, mapping=None, *, ignore_unknown_fields=False, **kwargs): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallels the
to_jsonmethod.Also adds options to ignore unknown fields during deserializtion.
Closes #153
Closes #151