Skip to content

Conversation

@rinarakaki
Copy link
Contributor

@rinarakaki rinarakaki commented Oct 15, 2024

Tracking issue googleapis/google-cloud-python#13171

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki rinarakaki requested review from a team as code owners October 15, 2024 03:47
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 15, 2024
@rinarakaki rinarakaki changed the title feature: migrate to pyproject.toml feat: migrate to pyproject.toml Oct 16, 2024
@parthea parthea self-assigned this Oct 19, 2024
Copy link
Collaborator

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rinarakaki!

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 19, 2024
@parthea
Copy link
Collaborator

parthea commented Oct 19, 2024

Adding do not merge until #729 is merged to avoid delaying the Python 3.13 release.

@parthea parthea removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. process: review requested labels Oct 28, 2024
@parthea parthea merged commit 159e9a4 into googleapis:main Oct 28, 2024
@rinarakaki rinarakaki deleted the pyproject branch October 28, 2024 16:15
@rinarakaki
Copy link
Contributor Author

@parthea thanks for the review and the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants