Skip to content

test: Move tests/unit/helpers to tests/unit/_helpers #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Mar 22, 2022
Merged

test: Move tests/unit/helpers to tests/unit/_helpers #1169

gcf-merge-on-green merged 2 commits into from
Mar 22, 2022

Conversation

@waltaskew
Copy link
Contributor

@waltaskew waltaskew commented Mar 16, 2022 •
edited
Loading

Remove ambiguity between importing tests/unit/helpers and tests/unit/helpers.py
which can lead to import errors.

Renamed directory _helpers matches the google.cloud.bigquery._helpers module
being tested.

Fixes #1168 🦕

@waltaskew waltaskew requested a review from a team March 16, 2022 23:10
@waltaskew waltaskew requested a review from a team as a code owner March 16, 2022 23:10
@waltaskew waltaskew requested a review from tswast March 16, 2022 23:10
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 16, 2022
@waltaskew
fix: move tests/unit/helpers to tests/unit/helpers
97e55ae 
Remove ambiguity between importing tests/unit/helpers and tests/unit/helpers.py
which can lead to import errors.

Renamed directory _helpers matches the google.cloud.bigquery._helpers module
being tested.
@parthea parthea changed the title Move tests/unit/helpers to tests/unit/helpers test: Move tests/unit/helpers to tests/unit/_helpers Mar 17, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2022
@tswast
Copy link
Contributor

tswast commented Mar 17, 2022

Re: Kokoro failures, the TestClient.test__initiate_resumable_upload test failures are due to a recent resumable media release. I believe it only affects the (overly strict) unit test assertions, and don't actually indicate a problem. That said, we'll need to patch that before we can merge this.

@waltaskew
Copy link
Contributor Author

waltaskew commented Mar 18, 2022

Re: Kokoro failures, the TestClient.test__initiate_resumable_upload test failures are due to a recent resumable media release. I believe it only affects the (overly strict) unit test assertions, and don't actually indicate a problem. That said, we'll need to patch that before we can merge this.

Is there an open issue for this? Anyone working on it? I can take a crack at it if no one else has already started.

@waltaskew
Copy link
Contributor Author

waltaskew commented Mar 22, 2022 •
edited
Loading

Re: Kokoro failures, the TestClient.test__initiate_resumable_upload test failures are due to a recent resumable media release. I believe it only affects the (overly strict) unit test assertions, and don't actually indicate a problem. That said, we'll need to patch that before we can merge this.

Look like this was fixed over here: #1171

Can we give this PR another shot at merging, @tswast ?

@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. automerge Merge the pull request once unit tests and other checks pass. labels Mar 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit d7f3e8d into googleapis:main Mar 22, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 22, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@waltaskew @abdelmegahedgoogle
test: Move tests/unit/helpers to tests/unit/_helpers (googleapis#1169)
025a904 
Remove ambiguity between importing tests/unit/helpers and tests/unit/helpers.py
which can lead to import errors.

Renamed directory _helpers matches the google.cloud.bigquery._helpers module
being tested.

Fixes googleapis#1168 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import Ambiguity For 'google.cloud.bigquery.tests.unit.helpers'

4 participants

@waltaskew @tswast @parthea @yoshi-kokoro