Skip to content

feat: add __str__ method to DatasetReference #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mattix23 merged 8 commits into from
Jan 30, 2023
Merged

feat: add __str__ method to DatasetReference #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51474ae
feat: add __str__ method to DatasetReference
Mattix23 Jan 25, 2023
f7dd2ce
Merge branch 'main' into issue1289-str_method_datasetrefrence
Mattix23 Jan 25, 2023
6931f0e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 25, 2023
383b528
Merge branch 'issue1289-str_method_datasetrefrence' of https://github…
gcf-owl-bot[bot] Jan 25, 2023
4171e6b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 25, 2023
4fd5ac8
Merge branch 'issue1289-str_method_datasetrefrence' of https://github…
gcf-owl-bot[bot] Jan 25, 2023
0132286
Merge branch 'main' into issue1289-str_method_datasetrefrence
Mattix23 Jan 30, 2023
b25013f
Merge branch 'main' into issue1289-str_method_datasetrefrence
Mattix23 Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions google/cloud/bigquery/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ def __ne__(self, other):
def __hash__(self):
return hash(self._key())

def __str__(self):
return f"{self.project}.{self._dataset_id}"

def __repr__(self):
return "DatasetReference{}".format(self._key())

Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,10 @@ def test___repr__(self):
expected = "DatasetReference('project1', 'dataset1')"
self.assertEqual(repr(dataset), expected)

def test___str__(self):
dataset = self._make_one("project1", "dataset1")
self.assertEqual(str(dataset), "project1.dataset1")


class TestDataset(unittest.TestCase):
from google.cloud.bigquery.dataset import DatasetReference
Expand Down