Skip to content

feat: expose configuration property on CopyJob, ExtractJob, LoadJob, QueryJob #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 3 commits into from
Mar 14, 2023
Merged

feat: expose configuration property on CopyJob, ExtractJob, LoadJob, QueryJob #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35f6782
feat: expose configuration property on CopyJob, ExtractJob, LoadJob, …
tswast Mar 10, 2023
b5b418b
E google.api_core.exceptions.BadRequest: 400 Clone operatio…
tswast Mar 10, 2023
c0e2e52
Merge branch 'main' into tswast-unit-test-false-positives
tswast Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions google/cloud/bigquery/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1976,15 +1976,8 @@ def create_job(
)
destination = _get_sub_prop(job_config, ["copy", "destinationTable"])
destination = TableReference.from_api_repr(destination)
sources = []
Copy link
Contributor Author

@tswast tswast Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a unit test failing because we were actually transforming "sourceTable" to "sourceTables" without this change.

source_configs = _get_sub_prop(job_config, ["copy", "sourceTables"])
if source_configs is None:
source_configs = [_get_sub_prop(job_config, ["copy", "sourceTable"])]
for source_config in source_configs:
table_ref = TableReference.from_api_repr(source_config)
sources.append(table_ref)
return self.copy_table(
sources,
[], # Source table(s) already in job_config resource.
destination,
job_config=typing.cast(CopyJobConfig, copy_job_config),
retry=retry,
Expand Down
Loading