bug: add type checking to prevent object issues #1649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
Collaborator
Author
|
The following tests are failing due to a known issue related to an incompatibility with Pandas 2.0 that is being resolved in an alternate PR: #1616. These two failures should not preclude this PR from being merged.
On the other hand... I don't have a resolution for the issues in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix attempts to overcome a backwards incompatible fix related to how python-api-core handles default timeout values and how bigquery handles default timeout values.
Namely:
the default timeout value in python-api-core is a Python object()
python-bigquery expects a value of None or a numeric value
This fix checks to see if the value being passed in is an object(), and if so, converts it to a NoneType value of None.
A similar fix can be found in PR: #1541
Fixes #1612 🦕