Skip to content

Conversation

@mistercrunch
Copy link
Contributor

@mistercrunch mistercrunch commented Nov 12, 2020

all the details here: #377

I guess technically a script isn't DML :trollface:

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 12, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@tswast
Copy link
Contributor

tswast commented Nov 12, 2020

Makes sense to me.

Actually, we can probably consider removing the is_dml logic altogether now that we moved to getQueryResults instead of tabledata.list (#375). The destination table of a DML query would return a non-null value that was unreadable or would return nonsense with DML (and some DDL) queries. Before we do that, I'll want to double-check that we have a system test for this case. (I think a DDL to CREATE VIEW would be a good choice for that)

@mistercrunch
Copy link
Contributor Author

Superseded by #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants