feat: add 'Client.close' #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tseaver
force-pushed
the
64-add-client-close
branch
from
ef3bbf0 to
090a970
Compare
FBO use with 'contextlib.closing'. Closes #64.
tseaver
force-pushed
the
64-add-client-close
branch
from
51b77e2 to
71b94c6
Compare
Merged
chrisrossi
approved these changes
Jun 14, 2021
chrisrossi
left a comment
chrisrossi
left a comment
There was a problem hiding this comment.
LGTM! I hadn't heard of contextlib.closing.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.7.0](https://www.github.com/googleapis/python-cloud-core/compare/v1.6.0...v1.7.0) (2021-06-14) ### Features * add 'Client.close' ([#100](https://www.github.com/googleapis/python-cloud-core/issues/100)) ([7387fc8](https://www.github.com/googleapis/python-cloud-core/commit/7387fc87186defff74612cf85909c7d456155d47)) * add 'Client.from_service_account_info' factory ([#54](https://www.github.com/googleapis/python-cloud-core/issues/54)) ([7e59360](https://www.github.com/googleapis/python-cloud-core/commit/7e59360a43418947cbbb7608aa23ef5d566c964c)) ### Documentation * update python contributing guide ([#80](https://www.github.com/googleapis/python-cloud-core/issues/80)) ([58deef8](https://www.github.com/googleapis/python-cloud-core/commit/58deef8ce2e90415a4c38022e88fdfe25bc666b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FBO use with 'contextlib.closing'.
Closes #64.