Skip to content

bug: add import and object reference due to upstream changes #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 1 commit into from
Aug 31, 2023
Merged

bug: add import and object reference due to upstream changes #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/compliance/date/test_date_compliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

import pandas
from pandas.tests.extension import base
import pandas._testing as tm
Copy link
Collaborator

@tswast tswast Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's actually a public module for this. Let's use that.

https://pandas.pydata.org/docs/reference/api/pandas.testing.assert_series_equal.html#pandas-testing-assert-series-equal

import pytest

import db_dtypes
Expand Down Expand Up @@ -88,7 +89,7 @@ def test_value_counts(self, all_data, dropna):
result = pandas.Series(all_data).value_counts(dropna=dropna).sort_index()
expected = pandas.Series(other).value_counts(dropna=dropna).sort_index()

self.assert_series_equal(result, expected)
tm.assert_series_equal(result, expected)

def test_diff(self):
pytest.xfail(
Expand Down
3 changes: 2 additions & 1 deletion tests/compliance/time/test_time_compliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

import pandas
from pandas.tests.extension import base
import pandas._testing as tm
import pytest

import db_dtypes
Expand Down Expand Up @@ -88,7 +89,7 @@ def test_value_counts(self, all_data, dropna):
result = pandas.Series(all_data).value_counts(dropna=dropna).sort_index()
expected = pandas.Series(other).value_counts(dropna=dropna).sort_index()

self.assert_series_equal(result, expected)
tm.assert_series_equal(result, expected)


class TestParsing(base.BaseParsingTests):
Expand Down