-
Notifications
You must be signed in to change notification settings - Fork 57
Closed
Labels
api: loggingIssues related to the googleapis/python-logging API.Issues related to the googleapis/python-logging API.lang: pythonIssues specific to Python.Issues specific to Python.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Right now, we detect whether to add a filter by scanning the user-input filter string for the word timestamp, and add one if it's missing. @nicoleczhu mentioned an edge case where the timestamp won't be added if the user is filtering for logs containing the text 'timestamp`. We should think of ways to make the logic more intelligent here
This is low priority, because the failure case isn't too severe. The user will just have to add their own timestamp when they notice the query is taking a long time
Metadata
Metadata
Assignees
Labels
api: loggingIssues related to the googleapis/python-logging API.Issues related to the googleapis/python-logging API.lang: pythonIssues specific to Python.Issues specific to Python.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.