Skip to content

[CHANGE ME] Re-generated to pick up changes in the API or client library generator. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoshi-automation wants to merge 39 commits into from
Closed

[CHANGE ME] Re-generated to pick up changes in the API or client library generator. #59

yoshi-automation wants to merge 39 commits into from

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Aug 5, 2020 •
edited
Loading

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/86ec5a02-193b-4725-a427-0aec843e8c4a/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@da5c605
Source-Link: googleapis/synthtool@477764c
PiperOrigin-RevId: 336682434
Source-Link: googleapis/googleapis@438e615
Source-Link: googleapis/synthtool@9b0da52
Source-Link: googleapis/synthtool@f3c0488
PiperOrigin-RevId: 333125205
Source-Link: googleapis/googleapis@4ede775
Source-Link: googleapis/googleapis@aaac658
Source-Link: googleapis/synthtool@27f4406
Source-Link: googleapis/synthtool@dba48bb
Source-Link: googleapis/synthtool@257fda1
Source-Link: googleapis/synthtool@ffcee79
Source-Link: googleapis/synthtool@d302f93
Source-Link: googleapis/synthtool@d91dd8a
PiperOrigin-RevId: 327026955
Source-Link: googleapis/googleapis@0dc0a6c
Source-Link: googleapis/synthtool@4f8f5dc
Source-Link: googleapis/synthtool@bfcdbe0
Source-Link: googleapis/synthtool@39b527a
Source-Link: googleapis/synthtool@5dfda56
Source-Link: googleapis/synthtool@ee7506d
Source-Link: googleapis/synthtool@f07cb44
PiperOrigin-RevId: 320411362
Source-Link: googleapis/googleapis@db69b46
PiperOrigin-RevId: 320016414
Source-Link: googleapis/googleapis@aba9760
Source-Link: googleapis/synthtool@3032717
PiperOrigin-RevId: 318028816
Source-Link: googleapis/googleapis@b882b8e
PiperOrigin-RevId: 317949519
Source-Link: googleapis/googleapis@7157f95
Source-Link: googleapis/synthtool@cd522c3
PiperOrigin-RevId: 316182409
Source-Link: googleapis/googleapis@1846617
PiperOrigin-RevId: 316038172
Source-Link: googleapis/googleapis@e0558da
PiperOrigin-RevId: 315548189
Source-Link: googleapis/googleapis@ca1372c
Source-Link: googleapis/synthtool@e99975b
Source-Link: googleapis/synthtool@ffe1040
Source-Link: googleapis/synthtool@71b8a27
PiperOrigin-RevId: 313460921
Source-Link: googleapis/googleapis@c4e3701
PiperOrigin-RevId: 312689208
Source-Link: googleapis/googleapis@dec3204
Source-Link: googleapis/synthtool@d2364eb
PiperOrigin-RevId: 312088359
Source-Link: googleapis/googleapis@5a90d46
Source-Link: googleapis/synthtool@7482e79
Source-Link: googleapis/synthtool@09c4846
PiperOrigin-RevId: 309824146
Source-Link: googleapis/googleapis@e0f9d9e

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
tseaver
tseaver suggested changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is huge, and contains both "housekeeping" changes (adding the docs build) and a bunch of substantive, even breaking changes to the protoc-generated surface. Please hold of merging it until those issues are hashed out.

docs/gapic/v2/api.rst Outdated
@@ -1,5 +1,5 @@
Client for Stackdriver Logging API
==================================
Client for Cloud Logging API
Copy link
Contributor

@tseaver tseaver Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96 Is this branding change intended?

Copy link

@simonz130 simonz130 Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Cloud Logging is a new brand name

google/cloud/logging_v2/gapic/config_service_v2_client.py Outdated
"""Return a fully-qualified billing_account string."""
return google.api_core.path_template.expand(
"billingAccounts/{billing_account}", billing_account=billing_account,
)
Copy link
Contributor

@tseaver tseaver Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a huge set of potentially breaking changes.

Copy link
Contributor

@busunkim96 busunkim96 Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, lots of breaking changes. I looked at previous iterations of this PR and basically decided it was too much to patch over with synth replaces (path helper removals, path helper renames, method params being reordered).

@simonz130 I'd prefer to continue to let this sit and take the breaking changes when this library moves to the microgenerator. Is that alright with you? I'll also need to sync with you at some point about what to do with the handwritten layer.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 5, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Aug 21, 2020
@daniel-sanche daniel-sanche mentioned this pull request Oct 13, 2020
Merged
@daniel-sanche daniel-sanche requested a review from a team as a code owner October 14, 2020 00:20
@yoshi-automation
Integrate Python GAPIC Microgenerator in googleapis. This PR uses usi…
9ea7ef6 
…ng documentai as an example. Depends on googleapis/gapic-generator-python#402

PiperOrigin-RevId: 309824146

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 15:06:44 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb
Source-Link: googleapis/googleapis@e0f9d9e
@yoshi-automation
chore(python): create thread_safety doc
2aec090 
This will be included in index.rst files. See https://github.com/googleapis/python-bigtable/pull/26/files

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue May 5 10:06:52 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 09c48461232ce929c34386259eb59018ad2d8eef
Source-Link: googleapis/synthtool@09c4846
@yoshi-automation
chore(python): remove extra #!/bin/bash
cf7c72f 
Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue May 12 09:51:12 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 7482e79a82e353248769d819788adc1213e8c207
Source-Link: googleapis/synthtool@7482e79
@yoshi-automation
fix: restore GAPIC v2 retry configs
79d1eb4 
Restores GAPIC v2 retry config overrides that were
mistakenly removed during migration.

PiperOrigin-RevId: 312088359

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 18 08:57:12 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c
Source-Link: googleapis/googleapis@5a90d46
@yoshi-automation
chore(python): remove one remaining extra bash line
72d84b8 
To avoid generating bogus PRs

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Carlos de la Guardia <cguardia@yahoo.com>
Source-Date: Tue May 19 11:57:19 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e
Source-Link: googleapis/synthtool@d2364eb
@yoshi-automation
Upgrade protoc-docs-plugin version to 0.7.0 to fix unstable docstrings.
66e9e65 
PiperOrigin-RevId: 312689208

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 21 10:00:47 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: dec3204175104cef49bf21d685d5517caaf0058f
Source-Link: googleapis/googleapis@dec3204
@yoshi-automation
bazel: update protobuf, rules_go, gazelle, and gapic-generator-go ver…
75e3bd5 
…sions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1

PiperOrigin-RevId: 313460921

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 27 14:10:16 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c4e37010d74071851ff24121f522e802231ac86e
Source-Link: googleapis/googleapis@c4e3701
@yoshi-automation
docs: update python docs template
753984e 
* docs: update python docs template

* sphinx change

Source-Author: kolea2 <45548808+kolea2@users.noreply.github.com>
Source-Date: Wed May 27 20:44:34 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 71b8a272549c06b5768d00fa48d3ae990e871bec
Source-Link: googleapis/synthtool@71b8a27
@yoshi-automation
feat: add templates for python samples projects
35abcfa 
These templates will be used for templates in python-docs-samples
and in Python client libraries. The README generation code is a modified
version of
https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/scripts/readme-gen.

Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 14:39:58 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ffe10407ee2f261c799fb0d01bf32a8abc67ed1e
Source-Link: googleapis/synthtool@ffe1040
@yoshi-automation
chore: update default ignores for Python libraries
0b4302e 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 14:43:37 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: e99975b6b49827b8720f0a885e218dbdb67849ca
Source-Link: googleapis/synthtool@e99975b
@yoshi-automation
Regular update of Google API service config with clarification of doc…
b578994 
…umentations.

BREAKING CHANGE: `features` field is no longer used. It has been removed from the API runtime for awhile.

PiperOrigin-RevId: 315548189

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Jun 9 13:27:00 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: ca1372c6d7bcb199638ebfdb40d2b2660bab7b88
Source-Link: googleapis/googleapis@ca1372c
@yoshi-automation
chore: set Ruby namespace in proto options
de33ccf 
PiperOrigin-RevId: 316038172

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Jun 11 21:09:51 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0558da52e48b9f1a4bd5104e6b5e219a48f1dec
Source-Link: googleapis/googleapis@e0558da
@yoshi-automation
fix: use protoc-docs-plugin 0.8.0
a14d351 
Fixes issue with missing newline before 'Attributes' in Python docstrings.

PiperOrigin-RevId: 316182409

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Jun 12 14:52:11 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 184661793fbe3b89f2b485c303e7466cef9d21a1
Source-Link: googleapis/googleapis@1846617
@yoshi-automation
fix(python): change autodoc_default_flags to autodoc_default_options
261e8af 
Source-Author: HemangChothani <50404902+HemangChothani@users.noreply.github.com>
Source-Date: Thu Jun 18 22:50:02 2020 +0530
Source-Repo: googleapis/synthtool
Source-Sha: cd522c3b4dde821766d95c80ae5aeb43d7a41170
Source-Link: googleapis/synthtool@cd522c3
@yoshi-automation
chore: update grpc to v1.30.0
b1913a4 
PiperOrigin-RevId: 317949519

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Jun 23 15:22:22 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 7157f9552747421572cf1ab3aec1105c05ebd4f9
Source-Link: googleapis/googleapis@7157f95
@yoshi-automation
Updates to build Google Ads API build files.
dc0a411 
PiperOrigin-RevId: 318028816

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Jun 24 02:32:38 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: b882b8e6bfcd708042ff00f7adc67ce750817dd0
Source-Link: googleapis/googleapis@b882b8e
@yoshi-automation
chore: update Py2 support msg to reflect passage of time
5f7ddbe 
Source-Author: Dan O'Meara <danom@google.com>
Source-Date: Mon Jun 29 13:20:01 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 303271797a360f8a439203413f13a160f2f5b3b4
Source-Link: googleapis/synthtool@3032717
@yoshi-automation
feat: Update Logging API protos.
f9b8687 
Renames the service name from Stackdriver Logging to Cloud Logging. Specifies client retry behavior and a few other documentation updates.

PiperOrigin-RevId: 320016414

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Jul 7 10:52:01 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: aba9760d6abc15f724753c26d6f306e0f76dd11a
Source-Link: googleapis/googleapis@aba9760
@yoshi-automation
Update protobuf and gapic-generator-csharp versions.
e0be185 
PiperOrigin-RevId: 320411362

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Jul 9 09:26:49 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: db69b46790b55a82ab7cfa473d031da787bc7591
Source-Link: googleapis/googleapis@db69b46
@yoshi-automation
feat(python-library): changes to docs job
c68b581 
* feat(python-library): changes to docs job

* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket

* remove redundant envvars

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Wed Jul 29 16:15:18 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: f07cb4446192952f19be3056957f56d180586055
Source-Link: googleapis/synthtool@f07cb44
@yoshi-automation
Revert "feat(python-library): changes to docs job (#700)"
048ba62 
This reverts commit f07cb4446192952f19be3056957f56d180586055.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Jul 29 17:33:57 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ee7506d15daa3873accfff9430eff7e3953f0248
Source-Link: googleapis/synthtool@ee7506d
@yoshi-automation
feat(python-library): changes to docs job
dc96dcc 
* feat(python-library): changes to docs job

* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket

* remove redundant envvars

* add a failing test first

* fix TemplateSyntaxError: Missing end of comment tag

* serving_path is not needed any more

* use `raw` to make jinja happy

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Jul 30 12:44:02 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5dfda5621df45b71b6e88544ebbb53b1a8c90214
Source-Link: googleapis/synthtool@5dfda56
@yoshi-automation
fix(python-library): add missing changes
6504e5b 
Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Jul 30 18:26:35 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 39b527a39f5cd56d4882b3874fc08eed4756cebe
Source-Link: googleapis/synthtool@39b527a
@yoshi-automation
chore(py_library): add split_system_tests
ea14f8a 
Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Jul 31 16:17:13 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: bfcdbe0da977b2de6c1c0471bb6dc2f1e13bf669
Source-Link: googleapis/synthtool@bfcdbe0
@yoshi-automation
chore(py_library): add some excludes in docs/conf.py
2c7b42e 
This should fix build failures in python-bigquery.
Example:
googleapis/python-bigquery#205

* also add a comment

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Mon Aug 3 15:08:00 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 4f8f5dc24af79694887385015294e4dbb214c352
Source-Link: googleapis/synthtool@4f8f5dc
@yoshi-automation
Update protobuf workspace dependency to v3.13.0.
0a9625a 
PiperOrigin-RevId: 327026955

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Aug 17 08:40:22 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 0dc0a6c0f1a9f979bc0690f0caa5fbafa3000c2c
Source-Link: googleapis/googleapis@0dc0a6c
@yoshi-automation
chore(py-library): enable snippet-bot
581cf7f 
Co-authored-by: Benjamin E. Coe <bencoe@google.com>

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Tue Sep 1 17:14:08 2020 +0000
Source-Repo: googleapis/synthtool
Source-Sha: d91dd8aac77f7a9c5506c238038a26fa4f9e361e
Source-Link: googleapis/synthtool@d91dd8a
@yoshi-automation
chore(py-library): update decrypt secrets file
1226d4f 
* chore(py-library): update decrypt secrets file

From https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/scripts/decrypt-secrets.sh

* docs: explain conditional

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue Sep 8 11:35:59 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: d302f93d7f47e2852e585ac35ab2d15585717ec0
Source-Link: googleapis/synthtool@d302f93
@yoshi-automation
chore(python-library): use sphinx 1.5.5 for the docfx job
2f306d4 
Originally tested at:
googleapis/python-texttospeech#89

This change will fix the missing docstring in the yaml files.

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Sep 10 04:12:14 2020 +0000
Source-Repo: googleapis/synthtool
Source-Sha: ffcee7952b74f647cbb3ef021d95422f10816fca
Source-Link: googleapis/synthtool@ffcee79
@yoshi-automation
build(python): use release-publish app for notifying GitHub of releas…
20e57c1 
* build(python): use release-publish app for notifying GitHub of release status

* fix: re-add pypi password

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Sep 16 08:46:42 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 257fda18168bedb76985024bd198ed1725485488
Source-Link: googleapis/synthtool@257fda1
@yoshi-automation
build(python): add secret manager in kokoro
78d3b8b 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Sep 16 10:24:40 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: dba48bb9bc6959c232bec9150ac6313b608fe7bd
Source-Link: googleapis/synthtool@dba48bb
@yoshi-automation
chore(python): add sphinx doctest extension
8cafbfd 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Mon Sep 21 13:09:57 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 27f4406999b1eee29e04b09b2423a8e4646c7e24
Source-Link: googleapis/synthtool@27f4406
@yoshi-automation
feat: Add Java microgen rules to imports
5e25f49 
Source-Author: Mira Leung <miraleung@users.noreply.github.com>
Source-Date: Mon Sep 21 18:04:02 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: aaac658367398e478d650768344b88acebad50d9
Source-Link: googleapis/googleapis@aaac658
@yoshi-automation
Publish SLM logging proto for documentation
f5a76ee 
PiperOrigin-RevId: 333125205

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Sep 22 11:39:20 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 4ede77543c77072a2ac9f78353de2de2f8c4c501
Source-Link: googleapis/googleapis@4ede775
@yoshi-automation
chore(python): skip reporting coverage for namespace package
153f08e 
Source-Author: Tres Seaver <tseaver@palladion.com>
Source-Date: Wed Sep 23 10:58:13 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: f3c04883d6c43261ff13db1f52d03a283be06871
Source-Link: googleapis/synthtool@f3c0488
@yoshi-automation
chore(python): use BUILD_SPECIFIC_GCLOUD_PROJECT for samples
1e325d0 
https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32

`BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Sep 30 13:06:03 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4
Source-Link: googleapis/synthtool@9b0da52
@yoshi-automation
chore: use python microgenerator rules for logging
3a087b1 
PiperOrigin-RevId: 336682434

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Oct 12 09:45:22 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 438e61571a44e1cd58f99cf8a8eb6163d0f0ee39
Source-Link: googleapis/googleapis@438e615
@yoshi-automation
build(python): samples tests should pass if no samples exist
93e24fd 
Source-Author: Daniel Sanche <d.sanche14@gmail.com>
Source-Date: Wed Oct 14 08:00:06 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 477764cc4ee6db346d3febef2bb1ea0abf27de52
Source-Link: googleapis/synthtool@477764c
@yoshi-automation
chore(python_library): change the docs bucket name
2804cbc 
Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Oct 16 09:58:05 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: da5c6050d13b4950c82666a81d8acd25157664ae
Source-Link: googleapis/synthtool@da5c605
@busunkim96 busunkim96 closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@busunkim96 busunkim96 busunkim96 left review comments

@simonz130 simonz130 simonz130 left review comments

@tseaver tseaver tseaver requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement. context: full do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @tseaver @busunkim96 @simonz130