Skip to content

Conversation

@release-please
Copy link
Contributor

@release-please release-please bot commented Aug 12, 2020

🤖 I have created a release *beep* *boop*

1.16.0 (2020-10-27)

Features

  • pass 'client_options' to super ctor (#61) (c4387b3), closes #55

Bug Fixes


This PR was generated with Release Please.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 12, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 12, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Aug 21, 2020
@release-please release-please bot requested a review from a team as a code owner September 24, 2020 15:23
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2020
@busunkim96
Copy link
Contributor

@daniel-sanche Merging this will release the library

@daniel-sanche
Copy link
Contributor

@daniel-sanche Merging this will release the library

Do you think it makes sense to make a release soon? Or should we wait until the microgenerator changes are in and do a major release then?

@simonz130
Copy link

@daniel-sanche Merging this will release the library

Do you think it makes sense to make a release soon? Or should we wait until the microgenerator changes are in and do a major release then?

If it's a minor version update, we should aim for frequent releases over accumulating content and sparse releases.

@daniel-sanche
Copy link
Contributor

Some of my recent changes are incompatible with Python 2, which should count as a breaking change. And there are a lot more coming soon with changes around microgenerator update. I was thinking we should aim for one big major release after the microgenerator update, and then get back into a regular cadence of smaller releases. What do you think?

@busunkim96
Copy link
Contributor

Ah I didn't realize there were changes that dropped Python 2 support. If that's the case it is probably better to wait.

After that point I'd advocate for frequent releases. It's easier to figure out what the root cause of any bugs are, and rollbacks are less disruptive.

@daniel-sanche
Copy link
Contributor

FWIW It should be pretty easy to bring back Python 2 support if we decide another minor release is worthwhile. But yeah, I think a major release soon and then smaller ones after makes sense

@release-please release-please bot requested a review from a team as a code owner October 27, 2020 18:40
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 27, 2020
@release-please release-please bot closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/python-logging API. autorelease: closed cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants