-
Notifications
You must be signed in to change notification settings - Fork 66
fix: support ordering by key for multi queries #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support ordering by key for multi queries #630
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
f74f417 to
f4410be
Compare
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
@Primevenn This PR looks great. Thank you for submitting it. In order to accept this PR we'll need unit test coverage for the new code. There are also some linting errors that can be cleaned up by running Once you can run |
a4f175e to
ed18867
Compare
|
@chrisrossi Thanks for the review! As you suggested i've appended flat_path to the 2 lines under the if statement that handles ordering by Entity __ key __ and have moved the other if statements inside the else block. These 2 extra if statements are necessary for ordering by keyProperty since I've also added unit test coverage for these 2 scenarios and ran |
chrisrossi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thank you!
fix: support ordering by key for multi queries
Fixes #629