Skip to content

fix: process ErrorInfo / GRPC errors for ack/modack only when exactly-once delivery is enabled #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anguillanneuf merged 7 commits into from
Mar 29, 2022
Merged

fix: process ErrorInfo / GRPC errors for ack/modack only when exactly-once delivery is enabled #626

anguillanneuf merged 7 commits into from
Mar 29, 2022

Conversation

@pradn
Copy link
Contributor

@pradn pradn commented Mar 28, 2022

  • Don't process ErrorInfo / GRPC errors at all when exactly-once is disabled.
  • Don't retry temporary errors for ack/modack RPCs when exactly-once is disabled
  • Simplify completion of futures when a RetryError occurs (there's some duplication here but its simpler b/c we don't rely on subtle behavior in the process_errors function)
  • Update tests / get to 100% test coverage

@pradn
Process EOS/GRPC errors for ack/modack only when EOS is enabled; don'…
8a54f03 
…t retry temporary errors for these RPCS when EOS is disabled.
@pradn pradn requested review from a team as code owners March 28, 2022 17:38
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 28, 2022
@pradn
Copy link
Contributor Author

pradn commented Mar 28, 2022

Lint broken b/c psf/black#2964

acocuzzo
acocuzzo approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradn
Copy link
Contributor Author

pradn commented Mar 28, 2022

Waiting for upstream linter fix to make it to our CI.

@pradn pradn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2022
@pradn pradn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@pradn pradn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@pradn pradn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@anguillanneuf anguillanneuf merged commit cc1953b into googleapis:main Mar 29, 2022
@release-please release-please bot mentioned this pull request Mar 29, 2022
Closed
@acocuzzo acocuzzo mentioned this pull request Apr 5, 2022
Closed
@release-please release-please bot mentioned this pull request Apr 6, 2022
Merged
@Tonow Tonow mentioned this pull request May 23, 2022
Closed
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maheshgattani maheshgattani maheshgattani approved these changes

@acocuzzo acocuzzo acocuzzo approved these changes

Assignees

@acocuzzo acocuzzo

Labels

api: pubsub Issues related to the googleapis/python-pubsub API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pradn @maheshgattani @acocuzzo @anguillanneuf @yoshi-kokoro @parthea