Skip to content

tests: separate eod creation and receive in parallel tests #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acocuzzo merged 4 commits into from
Apr 22, 2022
Merged

tests: separate eod creation and receive in parallel tests #667

acocuzzo merged 4 commits into from
Apr 22, 2022

Conversation

@acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Apr 22, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #636🦕

@acocuzzo acocuzzo requested review from a team as code owners April 22, 2022 17:46
@acocuzzo acocuzzo requested a review from m-strzelczyk April 22, 2022 17:46
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Apr 22, 2022
@acocuzzo acocuzzo changed the title samples (tests): separate eod creation and receive in parallel tests tests: separate eod creation and receive in parallel tests Apr 22, 2022
anguillanneuf
anguillanneuf approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank. you Anna! May be good to share with @feywind who is also dealing with flaky tests.

@acocuzzo acocuzzo merged commit 2becf33 into googleapis:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@m-strzelczyk m-strzelczyk Awaiting requested review from m-strzelczyk m-strzelczyk was automatically assigned from googleapis/python-samples-owners

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

subscriber_test.test_receive_messages_with_exactly_once_delivery_enabled unit flaky

2 participants

@acocuzzo @anguillanneuf